Merge ~txiao/charm-nrpe:func-fix into charm-nrpe:master

Proposed by Tianqi Xiao
Status: Merged
Approved by: Tianqi Xiao
Approved revision: 36de66cadbaa2e4989307e07b97412d8576e1d10
Merged at revision: b2b029a74e49e5e54735fce1efc00ba592854f17
Proposed branch: ~txiao/charm-nrpe:func-fix
Merge into: charm-nrpe:master
Diff against target: 9 lines (+3/-0)
1 file modified
tests/functional/tests/bundles/overlays/xenial.yaml.j2 (+3/-0)
Reviewer Review Type Date Requested Status
Robert Gildein Approve
Erhan Sunar (community) Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
Review via email: mp+451476@code.launchpad.net

Commit message

Fix functional test by specifying a different channel for rabbitmq-server in xenial bundle

Description of the change

Xenial is not a supporting series in rabbitmq-server's default channel (3.9/stable). Specifying a different channel, 3.6/edge, for this charm to resolve functional test errors.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
Erhan Sunar (esunar) wrote :

Since there is no stable charm for xenial, LGTM

review: Approve
Revision history for this message
Robert Gildein (rgildein) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision b2b029a74e49e5e54735fce1efc00ba592854f17

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tests/functional/tests/bundles/overlays/xenial.yaml.j2 b/tests/functional/tests/bundles/overlays/xenial.yaml.j2
2index 2cfb90e..b33a5de 100644
3--- a/tests/functional/tests/bundles/overlays/xenial.yaml.j2
4+++ b/tests/functional/tests/bundles/overlays/xenial.yaml.j2
5@@ -1 +1,4 @@
6 series: xenial
7+applications:
8+ rabbitmq-server:
9+ channel: 3.6/edge

Subscribers

People subscribed via source and target branches

to all changes: