Merge ~txiao/charm-infra-node:xenial/stable into charm-infra-node:xenial/stable

Proposed by Tianqi Xiao
Status: Merged
Approved by: Tianqi Xiao
Approved revision: 66243d03c7ca542d6b5565b89651d5511d531f4f
Merged at revision: 66243d03c7ca542d6b5565b89651d5511d531f4f
Proposed branch: ~txiao/charm-infra-node:xenial/stable
Merge into: charm-infra-node:xenial/stable
Diff against target: 47 lines (+5/-3)
2 files modified
src/tests/functional/test_deploy.py (+4/-3)
src/wheelhouse.txt (+1/-0)
Reviewer Review Type Date Requested Status
Eric Chen Approve
Robert Gildein Approve
Review via email: mp+427740@code.launchpad.net

Commit message

Limit MartkupSafe package version for legacy support and update fixtures

Description of the change

- Limit MartkupSafe package version to < 2.0.0 for legacy support
- Update fixtures in functional tests to fix bug LP#1983398

func-test: https://pastebin.ubuntu.com/p/Yg65k4D3tQ/

To post a comment you must log in.
Revision history for this message
Robert Gildein (rgildein) wrote :

LGTM

review: Approve
Revision history for this message
Eric Chen (eric-chen) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/tests/functional/test_deploy.py b/src/tests/functional/test_deploy.py
2index d83e09a..4f1a913 100644
3--- a/src/tests/functional/test_deploy.py
4+++ b/src/tests/functional/test_deploy.py
5@@ -1,6 +1,7 @@
6 import os
7 from collections import defaultdict
8 import pytest
9+import pytest_asyncio
10 from juju.model import Model
11
12 # Treat tests as coroutines
13@@ -12,7 +13,7 @@ nagios_series['xenial'] = "xenial"
14 charm_location = os.getenv('CHARM_LOCATION', '.').rstrip('/')
15
16
17-@pytest.fixture
18+@pytest_asyncio.fixture
19 async def model():
20 model = Model()
21 await model.connect_current()
22@@ -20,7 +21,7 @@ async def model():
23 await model.disconnect()
24
25
26-@pytest.fixture
27+@pytest_asyncio.fixture
28 async def apps(model):
29 apps = []
30 for entry in series:
31@@ -29,7 +30,7 @@ async def apps(model):
32 return apps
33
34
35-@pytest.fixture
36+@pytest_asyncio.fixture
37 async def units(apps):
38 units = []
39 for app in apps:
40diff --git a/src/wheelhouse.txt b/src/wheelhouse.txt
41new file mode 100644
42index 0000000..36f0d40
43--- /dev/null
44+++ b/src/wheelhouse.txt
45@@ -0,0 +1 @@
46+MarkupSafe<2.0.0
47\ No newline at end of file

Subscribers

People subscribed via source and target branches

to all changes: