Merge lp:~txerpa/account-payment/7.0-account_payment-call-move-post into lp:~account-payment-team/account-payment/7.0

[Biel - txerpa.com]

When creating an order with the direct payment option and the entry_posted option of the journal is chosen, it changes the status to posted of the move when it should call the post method.

http://bazaar.launchpad.net/~account-payment-team/account-payment/7.0/view/head:/account_payment_extension/account_payment.py#L317

 # Post the move
 if order.mode.journal.entry_posted:
     move_obj.write(cr, uid, [move_id], {
        'state':'posted',
        }, context)

It should be:
if order.mode.journal.entry_posted:
    move_obj.post()

[Pedro Manuel Baeza (pedro.baeza)]

Thanks for the MP! In 6.1, it has been also changed in revision 111. It would be desirable to put context as a keyword argument (context=context), to avoid incompatibilities if the signature of post method changes.

Regards.

review: Approve (code review and test)

[xavi (xgilest)]

review: Approve

[Omar (Pexego) (omar7r)]

Need fixing status, while don't update it with context=context as Pedro said.

Thanks

review: Needs Fixing (code review)

[lp:~txerpa/account-payment/7.0-account_payment-call-move-post]

106. By Biel - txerpa.com on 2014-01-31

context as a keyword argument

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

I set this MP as Work in progress as it is in "Needs Fixing" since weeks. Please set it back to "Need Review" once you think you are done.

[Pedro Manuel Baeza (pedro.baeza)]

As the change is trivial, I'm going to make it on merge time, so I proceed with the merge.

Regards

review: Approve

[Pedro Manuel Baeza (pedro.baeza)]

Sorry, it was made already, but not notified with any comment.

=== modified file 'account_payment_extension/account_payment.py'
--- account_payment_extension/account_payment.py	2013-09-24 15:15:21 +0000
+++ account_payment_extension/account_payment.py	2014-01-31 09:52:16 +0000
@@ -316,9 +316,7 @@
                 }, context)
             # Post the move
             if order.mode.journal.entry_posted:
-                move_obj.write(cr, uid, [move_id], {
-                    'state':'posted',
-                }, context)
+                move_obj.post(cr, uid, [move_id], context=context)
 
         return result