Merge lp:~twstd-dev/ubuntu-clock-app/label-truncate into lp:ubuntu-clock-app

[twstd]

Simplified the alarm label page back button check function using javascript trim() function.

Simplified the alarm label page back button check function using javascript trim() function.

[Nekhelesh Ramananthan (nik90)]

Yup works as expected. Awesome!! Just a small code style tweak pls :P,

- onTextChanged: ( backAction.enabled = !!text.trim() )
+ onTextChanged: {
+ backAction.enabled = !!text.trim()
+ }

[lp:~twstd-dev/ubuntu-clock-app/label-truncate]

60. By twstd on 2014-08-18

Style change

[Nekhelesh Ramananthan (nik90)]

LGTM! Thx for the code reduction. I love deleting code :D

review: Approve

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'app/alarm/AlarmLabel.qml'
--- app/alarm/AlarmLabel.qml	2014-08-12 10:59:04 +0000
+++ app/alarm/AlarmLabel.qml	2014-08-18 21:30:26 +0000
@@ -50,22 +50,8 @@
             width: parent.width
             inputMethodHints: Qt.ImhNoPredictiveText
 
-            onTextChanged:  {
-                backAction.enabled = false
-
-                // If string is empty, reject it immediately
-                if(text === "") {
-                    backAction.enabled = false
-                    return
-                }
-
-                // Check if strings contain only blank spaces. If yes reject.
-                for (var i=0; i < text.length; i++) {
-                    if(text[i] !== " ") {
-                        backAction.enabled = true
-                        return
-                    }
-                }
+            onTextChanged: {
+                backAction.enabled = !!text.trim()
             }
         }
     }