Merge ~twom/launchpad:git-branch-picker-oops-with-no-repository into launchpad:master
Proposed by
Tom Wardill
Status: | Merged |
---|---|
Approved by: | Tom Wardill |
Approved revision: | 00f9a6f8dda52c7de64a993a16b542ff4333c438 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~twom/launchpad:git-branch-picker-oops-with-no-repository |
Merge into: | launchpad:master |
Diff against target: |
66 lines (+24/-7) 2 files modified
lib/lp/code/vocabularies/gitref.py (+6/-7) lib/lp/code/vocabularies/tests/test_gitref_vocabularies.py (+18/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thiago F. Pappacena (community) | Approve | ||
Review via email: mp+396678@code.launchpad.net |
Commit message
Fix OOPS with gitref widget form validation and missing repositories
Description of the change
On entering a repository that doesn't exist, the validation on gitref widget will fail to set the repository details on the vocabulary.
This seems like reasonable behaviour, given that the repository doesn't exist.
In this case, we should return no results from the vocabulary, rather than an AssertionError.
To post a comment you must log in.
LGTM