Merge ~twom/launchpad:stats-fix-valueerror-on-redirect into launchpad:master
Proposed by
Tom Wardill
Status: | Merged |
---|---|
Approved by: | Tom Wardill |
Approved revision: | c222314ab9f7ca17fcfff814a1da80e05a6fce34 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~twom/launchpad:stats-fix-valueerror-on-redirect |
Merge into: | launchpad:master |
Diff against target: |
58 lines (+23/-2) 2 files modified
lib/lp/services/webapp/publication.py (+9/-2) lib/lp/services/webapp/tests/test_publication.py (+14/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Colin Watson (community) | Approve | ||
Review via email: mp+391687@code.launchpad.net |
Commit message
Fix setting pageids in a redirect
Description of the change
Redirects don't have a view context. With the move to generating pageid at traversal rather than call time, we are now catching some redirects in this flow.
Check for RedirectionView on generation and allow the existing methods that deal with not having a context to DTRT.
To post a comment you must log in.
LGTM - could you update the MP description as well please?