Merge ~twom/launchpad:thread-state-not-in-state into launchpad:master
Proposed by
Tom Wardill
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Tom Wardill | ||||
Approved revision: | a10fc2cb90ef7f2aed909316af1ce64eaebbef00 | ||||
Merge reported by: | Otto Co-Pilot | ||||
Merged at revision: | not available | ||||
Proposed branch: | ~twom/launchpad:thread-state-not-in-state | ||||
Merge into: | launchpad:master | ||||
Diff against target: |
87 lines (+43/-1) 2 files modified
lib/lp/services/librarian/client.py (+3/-1) lib/lp/services/librarian/tests/test_client.py (+40/-0) |
||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Thiago F. Pappacena (community) | Approve | ||
Ioana Lasc (community) | Approve | ||
Review via email: mp+389327@code.launchpad.net |
Commit message
Move timeout out of local thread state
Description of the change
Keeping the timeout in the thread local (created in __init__) meant that if the _checkError method was called from another thread, the timeout value was missing.
Move it to a class attribute and add a test to ensure it's fixed.
Original work on the timeout test fix by ~pappacena in https:/
To post a comment you must log in.
looks good to me