Merge ~twom/launchpad:ocirecipe-allow-internet into launchpad:db-devel

Proposed by Tom Wardill
Status: Merged
Approved by: Colin Watson
Approved revision: c74bb8c6ade8fbd59755508e0222d6117d9584f5
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~twom/launchpad:ocirecipe-allow-internet
Merge into: launchpad:db-devel
Diff against target: 16 lines (+10/-0)
1 file modified
database/schema/patch-2210-18-0.sql (+10/-0)
Reviewer Review Type Date Requested Status
William Grant db Approve
Colin Watson (community) db Approve
Review via email: mp+387353@code.launchpad.net

Commit message

Add allow_internet to OCIRecipe

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) wrote :

LGTM; there are few enough rows at the moment that it should be fine, and I suppose it makes sense to default this to true for the time being at least.

Please get a second DB review from William, though.

review: Approve (db)
Revision history for this message
William Grant (wgrant) :
review: Approve (db)
Revision history for this message
Colin Watson (cjwatson) wrote :

Relanding after db-devel history surgery.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/database/schema/patch-2210-18-0.sql b/database/schema/patch-2210-18-0.sql
2new file mode 100644
3index 0000000..bf2dc28
4--- /dev/null
5+++ b/database/schema/patch-2210-18-0.sql
6@@ -0,0 +1,10 @@
7+-- Copyright 2020 Canonical Ltd. This software is licensed under the
8+-- GNU Affero General Public License version 3 (see the file LICENSE).
9+
10+SET client_min_messages=ERROR;
11+
12+ALTER TABLE OCIRecipe ADD COLUMN allow_internet boolean DEFAULT true NOT NULL;
13+
14+COMMENT ON COLUMN OCIRecipe.allow_internet IS 'If True, builds of this OCIRecipe may allow access to external network resources.';
15+
16+INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 18, 0);

Subscribers

People subscribed via source and target branches

to status/vote changes: