Merge ~twom/launchpad:codeimport-url-setters into launchpad:master
Proposed by
Tom Wardill
Status: | Merged |
---|---|
Approved by: | Tom Wardill |
Approved revision: | 35a3b8af62eacdf54766b10aa6049b9461d5b786 |
Merge reported by: | Otto Co-Pilot |
Merged at revision: | not available |
Proposed branch: | ~twom/launchpad:codeimport-url-setters |
Merge into: | launchpad:master |
Diff against target: |
81 lines (+22/-5) 5 files modified
lib/lp/code/browser/codeimport.py (+2/-3) lib/lp/code/configure.zcml (+2/-1) lib/lp/code/doc/codeimport.txt (+1/-1) lib/lp/code/interfaces/codeimport.py (+11/-0) lib/lp/code/model/codeimport.py (+6/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ioana Lasc (community) | Approve | ||
Review via email: mp+386241@code.launchpad.net |
Commit message
Use a separate setter for URL that calls into updateFromData
Description of the change
We want to allow URL on a codeimport to be set by a user with lower permissions than the other attributes, but still keep the same code flow of notifications, format checks etc.
Add an extra setter for URL (and only URL) with the new permissions, then call updateFromData to ensure everything else is correct.
To post a comment you must log in.
makes sense to me