Merge ~twom/launchpad:drop-not-null-on-git-path into launchpad:db-devel

Proposed by Tom Wardill
Status: Merged
Approved by: Tom Wardill
Approved revision: c6ef810bd94f8597ccc3768a11e8e0274f5a86c1
Merge reported by: Otto Co-Pilot
Merged at revision: not available
Proposed branch: ~twom/launchpad:drop-not-null-on-git-path
Merge into: launchpad:db-devel
Diff against target: 11 lines (+0/-2)
1 file modified
database/schema/patch-2210-08-4.sql (+0/-2)
Reviewer Review Type Date Requested Status
Colin Watson (community) db Approve
Review via email: mp+380048@code.launchpad.net

This proposal supersedes a proposal from 2020-02-28.

Commit message

Just drop the NOT NULL on OCIRecipe.git_path

Description of the change

We can't do this and add the constraint at the same time, it needs a code deploy between.

To post a comment you must log in.
Revision history for this message
Colin Watson (cjwatson) :
review: Approve (db)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/database/schema/patch-2210-08-4.sql b/database/schema/patch-2210-08-4.sql
2index 4656bb7..c2ca3fb 100644
3--- a/database/schema/patch-2210-08-4.sql
4+++ b/database/schema/patch-2210-08-4.sql
5@@ -3,6 +3,4 @@
6
7 ALTER TABLE OCIRecipe ALTER COLUMN git_path DROP NOT NULL;
8
9-ALTER TABLE OCIRecipe ADD CONSTRAINT consistent_git_ref CHECK ((git_repository IS NULL) = (git_path IS NULL));
10-
11 INSERT INTO LaunchpadDatabaseRevision VALUES (2210, 08, 4);

Subscribers

People subscribed via source and target branches

to status/vote changes: