lp:~tveronezi/juju-gui/change-requires-param

Branch merges

Merged into lp:juju-gui/experimental at revision 256

Juju GUI Hackers: Pending requested 2012-11-20

Diff: 1823 lines (+808/-847)

10 files modified

app/app.js (+1/-0)
app/models/charm.js (+2/-1)
app/models/models.js (+1/-0)
app/modules-debug.js (+8/-12)
app/store/charm.js (+1/-0)
test/test_app.js (+176/-191)
test/test_app_hotkeys.js (+52/-52)
test/test_model.js (+18/-25)
test/test_notifications.js (+454/-469)
test/test_notifier_widget.js (+95/-97)

api

Propose for merging

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1081205: minification with bad "requires" param

High

Fix Released

Link a bug report

Related blueprints

260. By Thiago Veronezi on 2012-11-20

code review

259. By Thiago Veronezi on 2012-11-20

code review

258. By Thiago Veronezi on 2012-11-20

code review

257. By Thiago Veronezi on 2012-11-20

make lint happy

256. By Thiago Veronezi on 2012-11-20

fix tests

255. By Thiago Veronezi on 2012-11-20

removing requires

254. By Thiago Veronezi on 2012-11-20

application hotkeys

The user can hit alt+e to open the environment view and alt+s to focus the
charm search field.

R=matthew.scott, benjamin.saller
CC=
https://codereview.appspot.com/6849078

253. By Gary Poster on 2012-11-20

Add favicon, tweak Makefile

Added the juju icon as a favicon, and then got lost in Makefile tweaks. Makefile now does not do unnecessary work, and no longer hides commands with @ so that we can see when we reintroduce unnecessary work. Also switch from a Makefile comment about the node_modules to a message generated by the Makefile.

R=thiago
CC=
https://codereview.appspot.com/6842072

252. By Brad Crittenden on 2012-11-20

Fix overflow on charm name.

The sections in the charm search results pane are fixed at 70px high.
Due to the way we construct the name, and the fact the charm authors
can set the name to be anything they want, some names exceed the
allotted one-line and wreak havoc on the layout.

Obvious lesson learned: any element with a fixed height and
user-supplied data must account for overflow.

The deploy button placement was also fixed.

Matt C. has seen screenshots of the truncation and offered tweaks on
the vertical spacing which are incorporated here.

R=matthew.scott, thiago
CC=
https://codereview.appspot.com/6843082

251. By Thiago Veronezi on 2012-11-19

Makefile does not support static file deployment

Full description here: https://bugs.launchpad.net/juju-gui/+bug/1078898

This branch does not support CSS minification. It only combines the third-party css files. The minification of the YUI and our custom CSS files is covered by another branch;

The "make debug" command starts the node.js server with the debug version of our application;

The "make server" command starts a python SimpleHTTPServer service with the production version of our application. Note that it is not possible to use REST with this version. It will be covered by another card;

R=bac, gary.poster
CC=
https://codereview.appspot.com/6844061