Merge lp:~tvec623/ubuntu-desktop-accomplishments/20120903-sudoku-accomplishment into lp:ubuntu-desktop-accomplishments

[Tony Vec]

Added: 4 accomplishments: Accomplishment checks if user has completed the four levels in Sudoku.
Fixed: removed Shotwell Accomplishment and improved categories by switching to "Gaming:Sudoku"

[Matt Fischer (mfisch)]

Sorry for the delay. I don't see any shotwell changes here, did you miss them?

review: Needs Fixing

[Rafał Cieślak (rafalcieslak256)]

Matt, there are no changes needed for the Shotwell accomplishment, Tony meant he fixed the fact that it was needlessly added in his previous MP.
I have reviewed these accomplishments and they seem very fine. The scripts are all correct, and metadata is fine.

One last thing that needs fixing is the category. Currently it's "Gaming:Sudoku", but other accomplishments use "Games:...", and therefore, to maintain consistency, sudoku accomplishments should use "Games:Sudoku".

Thanks for this work, Tony. A future tip: when you need to fix something in a MP, do not create a new branch and a separate MP, please commit changes to the same branch you have used for last MP and push changes there, they will be appended to the very same pending MP. This way we are less likely to miss your changes.

review: Needs Fixing

[Matt Fischer (mfisch)]

Tony,

Thanks for your work on this. Daniel picked up the code and is merging it in a new MP now and you will still get credit.

Unmerged revisions

=== modified file 'CATEGORIES'
--- CATEGORIES	2012-05-19 18:08:54 +0000
+++ CATEGORIES	2012-09-04 01:44:18 +0000
@@ -4,3 +4,4 @@
 
 Audio and Video
 Games
+Multimedia

=== modified file 'Changelog'
--- Changelog	2012-08-16 00:40:29 +0000
+++ Changelog	2012-09-04 01:44:18 +0000
@@ -13,3 +13,4 @@
 
  * Bug #1036960: Wrong Information in "Shared With Accomplishment Service" Accomplishment (BenHagan)
  * Bug #1013161: "Shared With Accomplishments Service" accomplishment is not fully defined (BenHagan )
+ * New feature: Sudoku Accomplishments added (Tony Vec)

=== added file 'accomplishments/ubuntu-desktop/en/gaming/sudoku_easy.accomplishment'
--- accomplishments/ubuntu-desktop/en/gaming/sudoku_easy.accomplishment	1970-01-01 00:00:00 +0000
+++ accomplishments/ubuntu-desktop/en/gaming/sudoku_easy.accomplishment	2012-09-04 01:44:18 +0000
@@ -0,0 +1,13 @@
+[accomplishment]
+title=Rookie Sudoku Player
+description=Win a Easy game of Sudoku
+collection=ubuntu-desktop
+category=Gaming:Sudoku
+icon=default.png
+summary = You can achieve this accomplishment by completing a game of Sudoku in the <b>Easy</b> difficulty .
+steps: Start Sudoku.
+    Select Easy game.
+    Fill out all the squares until the whole board is completed
+tips = There's no time limit, so no need to rush.
+    You can get extra help from sudoku's help menu (F1). 
+author = Tony Vec <[e-mail]>

=== added file 'accomplishments/ubuntu-desktop/en/gaming/sudoku_hard.accomplishment'
--- accomplishments/ubuntu-desktop/en/gaming/sudoku_hard.accomplishment	1970-01-01 00:00:00 +0000
+++ accomplishments/ubuntu-desktop/en/gaming/sudoku_hard.accomplishment	2012-09-04 01:44:18 +0000
@@ -0,0 +1,13 @@
+[accomplishment]
+title=All Star Sudoku Player
+description=Win a game of Sudoku in Hard
+collection=ubuntu-desktop
+category=Gaming:Sudoku
+icon=default.png
+summary = You can achieve this accomplishment by completing a game of Sudoku in the <b>Hard</b> difficulty .
+steps: Start Sudoku.
+    Select Hard game.
+    Fill out all the squares until the whole board is completed
+tips = There's no time limit, so no need to rush.
+    You can get extra help from sudoku's help menu (F1). 
+author = Tony Vec <[e-mail]>

=== added file 'accomplishments/ubuntu-desktop/en/gaming/sudoku_medium.accomplishment'
--- accomplishments/ubuntu-desktop/en/gaming/sudoku_medium.accomplishment	1970-01-01 00:00:00 +0000
+++ accomplishments/ubuntu-desktop/en/gaming/sudoku_medium.accomplishment	2012-09-04 01:44:18 +0000
@@ -0,0 +1,13 @@
+[accomplishment]
+title=Pro Sudoku Player
+description=Win a medium game of Sudoku
+collection=ubuntu-desktop
+category=Gaming:Sudoku
+icon=default.png
+summary = You can achieve this accomplishment by completing a game of Sudoku in the <b>Medium</b> difficulty .
+steps: Start Sudoku.
+    Select Medium game.
+    Fill out all the squares until the whole board is completed
+tips = There's no time limit, so no need to rush.
+    You can get extra help from sudoku's help menu (F1). 
+author = Tony Vec <[e-mail]>

=== added file 'accomplishments/ubuntu-desktop/en/gaming/sudoku_very_hard.accomplishment'
--- accomplishments/ubuntu-desktop/en/gaming/sudoku_very_hard.accomplishment	1970-01-01 00:00:00 +0000
+++ accomplishments/ubuntu-desktop/en/gaming/sudoku_very_hard.accomplishment	2012-09-04 01:44:18 +0000
@@ -0,0 +1,13 @@
+[accomplishment]
+title=Sudoku Master
+description=Win a game of Sudoku wtih the Very Hard difficulty
+collection=ubuntu-desktop
+category=Gaming:Sudoku
+icon=default.png
+summary = You can achieve this accomplishment by completing a game of Sudoku in the <b>Very Hard</b> difficulty .
+steps: Start Sudoku.
+    Select Very Hard game.
+    Fill out all the squares until the whole board is completed
+tips = There's no time limit, so no need to rush.
+    You can get extra help from sudoku's help menu (F1). 
+author = Tony Vec <[e-mail]>

=== added file 'scripts/ubuntu-desktop/gaming/sudoku_easy.py'
--- scripts/ubuntu-desktop/gaming/sudoku_easy.py	1970-01-01 00:00:00 +0000
+++ scripts/ubuntu-desktop/gaming/sudoku_easy.py	2012-09-04 01:44:18 +0000
@@ -0,0 +1,34 @@
+#!/usr/bin/python
+import sys
+import os
+
+homeDir = os.getenv('HOME')
+sudoku_path = os.path.join(homeDir,'.config/gnome-sudoku/puzzles/') 
+
+
+def get_finished_levels():
+    #Should save last finished results if already checked
+    #for now, just start with 0
+    last_checked = 0
+    try:
+        with open(sudoku_path+'finished') as finished:
+            return (list(finished)[last_checked:])
+    except IOError as e:
+        #file does not exist
+        sys.exit(1)
+
+#games have a '/n' for next games. Truncate before checking 
+finished_games = get_finished_levels() 
+
+try:
+    with open(sudoku_path+'easy') as f:
+        easy = f.read()
+        for game in finished_games:
+            if game[:-2] in easy:
+                #easy game has been completed
+                sys.exit(0)
+        #No completed games found in easy        
+        sys.exit(1)
+except IOError as e:
+    #list of game difficulty does not exist
+    sys.exit(1)

=== added file 'scripts/ubuntu-desktop/gaming/sudoku_hard.py'
--- scripts/ubuntu-desktop/gaming/sudoku_hard.py	1970-01-01 00:00:00 +0000
+++ scripts/ubuntu-desktop/gaming/sudoku_hard.py	2012-09-04 01:44:18 +0000
@@ -0,0 +1,34 @@
+#!/usr/bin/python
+import sys
+import os
+
+homeDir = os.getenv('HOME')
+sudoku_path = os.path.join(homeDir,'.config/gnome-sudoku/puzzles/') 
+
+
+def get_finished_levels():
+    #Should save last finished results if already checked
+    #for now, just start with 0
+    last_checked = 0
+    try:
+        with open(sudoku_path+'finished') as finished:
+            return (list(finished)[last_checked:])
+    except IOError as e:
+        #file does not exist
+        sys.exit(1)
+
+#games have a '/n' for next games. Truncate before checking 
+finished_games = get_finished_levels() 
+
+try:
+    with open(sudoku_path+'hard') as f:
+        hard = f.read()
+        for game in finished_games:
+            if game[:-2] in hard:
+                #hard game has been completed
+                sys.exit(0)
+        #No completed games found in hard        
+        sys.exit(1)
+except IOError as e:
+    #list of game difficulty does not exist
+    sys.exit(1)

=== added file 'scripts/ubuntu-desktop/gaming/sudoku_medium.py'
--- scripts/ubuntu-desktop/gaming/sudoku_medium.py	1970-01-01 00:00:00 +0000
+++ scripts/ubuntu-desktop/gaming/sudoku_medium.py	2012-09-04 01:44:18 +0000
@@ -0,0 +1,34 @@
+#!/usr/bin/python
+import sys
+import os
+
+homeDir = os.getenv('HOME')
+sudoku_path = os.path.join(homeDir,'.config/gnome-sudoku/puzzles/') 
+
+
+def get_finished_levels():
+    #Should save last finished results if already checked
+    #for now, just start with 0
+    last_checked = 0
+    try:
+        with open(sudoku_path+'finished') as finished:
+            return (list(finished)[last_checked:])
+    except IOError as e:
+        #file does not exist
+        sys.exit(1)
+
+#games have a '/n' for next games. Truncate before checking 
+finished_games = get_finished_levels() 
+
+try:
+    with open(sudoku_path+'medium') as f:
+        medium = f.read()
+        for game in finished_games:
+            if game[:-2] in medium:
+                #medium game has been completed
+                sys.exit(0)
+        #No completed games found in medium
+        sys.exit(1)
+except IOError as e:
+    #list of game difficulty does not exist
+    sys.exit(1)

=== added file 'scripts/ubuntu-desktop/gaming/sudoku_very_hard.py'
--- scripts/ubuntu-desktop/gaming/sudoku_very_hard.py	1970-01-01 00:00:00 +0000
+++ scripts/ubuntu-desktop/gaming/sudoku_very_hard.py	2012-09-04 01:44:18 +0000
@@ -0,0 +1,35 @@
+#!/usr/bin/python
+import sys
+import os
+
+homeDir = os.getenv('HOME')
+sudoku_path = os.path.join(homeDir,'.config/gnome-sudoku/puzzles/') 
+
+
+def get_finished_levels():
+    #Should save last finished results if already checked
+    #for now, just start with 0
+    last_checked = 0
+    try:
+        with open(sudoku_path+'finished') as finished:
+            return (list(finished)[last_checked:])
+    except IOError as e:
+        #file does not exist
+        sys.exit(1)
+
+
+#games have a '/n' for next games. Truncate before checking 
+finished_games = get_finished_levels() 
+
+try:
+    with open(sudoku_path+'very_hard', 'r') as f:
+        very_hard = f.read()
+        for game in finished_games:
+            if game[:-2] in very_hard:
+                #vestructure pry hard game has been completed
+                sys.exit(0)
+        #No completed games found in very hard
+        sys.exit(1)
+except IOError as e:
+    #list of game difficulty does not exist
+    sys.exit(1)