Merge lp:~tvansteenburgh/charms/precise/nova-compute-vmware/fix-tests into lp:charms/nova-compute-vmware

Proposed by Tim Van Steenburgh
Status: Needs review
Proposed branch: lp:~tvansteenburgh/charms/precise/nova-compute-vmware/fix-tests
Merge into: lp:charms/nova-compute-vmware
Diff against target: 59 lines (+14/-2)
2 files modified
Makefile (+9/-2)
config.yaml (+5/-0)
To merge this branch: bzr merge lp:~tvansteenburgh/charms/precise/nova-compute-vmware/fix-tests
Reviewer Review Type Date Requested Status
charmers Pending
Review via email: mp+234231@code.launchpad.net

Description of the change

Fix tests, proof.

To post a comment you must log in.

Unmerged revisions

106. By Tim Van Steenburgh

Fix tests, proof

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2014-06-17 14:43:14 +0000
3+++ Makefile 2014-09-11 00:09:54 +0000
4@@ -5,10 +5,14 @@
5 @flake8 --exclude hooks/charmhelpers hooks unit_tests
6 @charm proof
7
8-test:
9+test: .venv
10 @echo Starting tests...
11- @$(PYTHON) /usr/bin/nosetests --nologcapture --with-coverage -v unit_tests
12+ .venv/bin/nosetests --nologcapture --with-coverage -v unit_tests
13
14+.venv:
15+ sudo apt-get install -y python-virtualenv python-apt
16+ virtualenv .venv --system-site-packages
17+ .venv/bin/pip install -I nose
18
19 bin/charm_helpers_sync.py:
20 @mkdir -p bin
21@@ -21,3 +25,6 @@
22 publish: lint test
23 bzr push lp:charms/nova-compute-vmware
24 bzr push lp:charms/trusty/nova-compute-vmware
25+
26+clean:
27+ rm -rf .venv/ .coverage
28
29=== modified file 'config.yaml'
30--- config.yaml 2014-06-17 13:12:01 +0000
31+++ config.yaml 2014-09-11 00:09:54 +0000
32@@ -47,6 +47,7 @@
33 config-flags:
34 type: string
35 description: Comma separated list of key=value config flags to be set in nova.conf.
36+ default:
37 nagios_context:
38 default: "juju"
39 type: string
40@@ -61,15 +62,19 @@
41 host-ip:
42 type: string
43 description: IP address for connecting to VMware VC server.
44+ default:
45 host-username:
46 type: string
47 description: Username for authenticating with VMware VC server.
48+ default:
49 host-password:
50 type: string
51 description: Password for authenticating with VMware VC server.
52+ default:
53 cluster-name:
54 type: string
55 description: VMware Cluster name. Multiple clusters may be managed - space delimited.
56+ default:
57 flat-network-bridge:
58 type: string
59 default: br100

Subscribers

People subscribed via source and target branches