Merge lp:~tvansteenburgh/charms/precise/cinder-vmware/fix-proof into lp:charms/cinder-vmware

Proposed by Tim Van Steenburgh
Status: Needs review
Proposed branch: lp:~tvansteenburgh/charms/precise/cinder-vmware/fix-proof
Merge into: lp:charms/cinder-vmware
Diff against target: 47 lines (+13/-2)
2 files modified
Makefile (+10/-2)
config.yaml (+3/-0)
To merge this branch: bzr merge lp:~tvansteenburgh/charms/precise/cinder-vmware/fix-proof
Reviewer Review Type Date Requested Status
charmers Pending
Review via email: mp+234188@code.launchpad.net

Description of the change

Fix proof.

To post a comment you must log in.
Revision history for this message
Charles Butler (lazypower) wrote :

+1 LGTM

13. By Tim Van Steenburgh

Fix tests

Unmerged revisions

13. By Tim Van Steenburgh

Fix tests

12. By Tim Van Steenburgh

Fix proof

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2014-06-16 10:58:10 +0000
3+++ Makefile 2014-09-11 14:23:41 +0000
4@@ -6,9 +6,14 @@
5 @flake8 --exclude hooks/charmhelpers unit_tests
6 @charm proof
7
8-test:
9+test: .venv
10 @echo Starting tests...
11- @$(PYTHON) /usr/bin/nosetests --nologcapture -v unit_tests
12+ .venv/bin/nosetests --nologcapture -v unit_tests
13+
14+.venv:
15+ sudo apt-get install python-virtualenv
16+ virtualenv .venv
17+ .venv/bin/pip install nose mock pyyaml
18
19 bin/charm_helpers_sync.py:
20 @mkdir -p bin
21@@ -21,3 +26,6 @@
22 publish: test lint
23 bzr push lp:charms/cinder-vmware
24 bzr push lp:charms/trusty/cinder-vmware
25+
26+clean:
27+ rm -rf .venv
28
29=== modified file 'config.yaml'
30--- config.yaml 2014-06-16 11:01:16 +0000
31+++ config.yaml 2014-09-11 14:23:41 +0000
32@@ -1,12 +1,15 @@
33 options:
34 host-username:
35 type: string
36+ default:
37 description: Username for authenticating with VMware VC server.
38 host-password:
39 type: string
40+ default:
41 description: Password for authenticating with VMware VC server.
42 host-ip:
43 type: string
44+ default:
45 description: IP address for connecting to VMware VC server.
46 volume-folder:
47 type: string

Subscribers

People subscribed via source and target branches