Merge lp:~tvansteenburgh/charm-helpers/doc-updates into lp:charm-helpers

Proposed by Tim Van Steenburgh
Status: Merged
Merged at revision: 192
Proposed branch: lp:~tvansteenburgh/charm-helpers/doc-updates
Merge into: lp:charm-helpers
Diff against target: 104 lines (+17/-21)
6 files modified
charmhelpers/core/services/base.py (+2/-2)
charmhelpers/core/services/helpers.py (+1/-1)
docs/api/charmhelpers.contrib.jujugui.rst (+0/-16)
docs/api/charmhelpers.contrib.rst (+0/-1)
docs/api/charmhelpers.core.rst (+14/-0)
setup.py (+0/-1)
To merge this branch: bzr merge lp:~tvansteenburgh/charm-helpers/doc-updates
Reviewer Review Type Date Requested Status
Charles Butler (community) Approve
Review via email: mp+229696@code.launchpad.net

Description of the change

Update docs to match recent branches:

- Removed references to jujugui
- Added core.services docs

To post a comment you must log in.
Revision history for this message
Charles Butler (lazypower) wrote :

+1 LGTM

Revision history for this message
Charles Butler (lazypower) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'charmhelpers/core/services/base.py'
2--- charmhelpers/core/services/base.py 2014-08-05 13:02:58 +0000
3+++ charmhelpers/core/services/base.py 2014-08-05 21:31:00 +0000
4@@ -26,7 +26,7 @@
5 setup tasks, in the most declarative way possible.
6
7 Service definitions are dicts in the following formats (all keys except
8- 'service' are optional):
9+ 'service' are optional)::
10
11 {
12 "service": <service name>,
13@@ -79,7 +79,7 @@
14
15 The following registers an Upstart service called bingod that depends on
16 a mongodb relation and which runs a custom `db_migrate` function prior to
17- restarting the service, and a Runit service called spadesd.
18+ restarting the service, and a Runit service called spadesd::
19
20 manager = services.ServiceManager([
21 {
22
23=== modified file 'charmhelpers/core/services/helpers.py'
24--- charmhelpers/core/services/helpers.py 2014-08-05 13:02:58 +0000
25+++ charmhelpers/core/services/helpers.py 2014-08-05 21:31:00 +0000
26@@ -73,7 +73,7 @@
27 If you only care about a single unit on the relation, you can just
28 access it as `{{ interface[0]['key'] }}`. However, if you can at all
29 support multiple units on a relation, you should iterate over the list,
30- like:
31+ like::
32
33 {% for unit in interface -%}
34 {{ unit['key'] }}{% if not loop.last %},{% endif %}
35
36=== removed file 'docs/api/charmhelpers.contrib.jujugui.rst'
37--- docs/api/charmhelpers.contrib.jujugui.rst 2014-06-09 14:56:35 +0000
38+++ docs/api/charmhelpers.contrib.jujugui.rst 1970-01-01 00:00:00 +0000
39@@ -1,16 +0,0 @@
40-charmhelpers.contrib.jujugui package
41-====================================
42-
43-charmhelpers.contrib.jujugui.utils module
44------------------------------------------
45-
46-.. automodule:: charmhelpers.contrib.jujugui.utils
47- :members:
48- :undoc-members:
49- :show-inheritance:
50-
51-
52-.. automodule:: charmhelpers.contrib.jujugui
53- :members:
54- :undoc-members:
55- :show-inheritance:
56
57=== modified file 'docs/api/charmhelpers.contrib.rst'
58--- docs/api/charmhelpers.contrib.rst 2014-06-09 14:56:35 +0000
59+++ docs/api/charmhelpers.contrib.rst 2014-08-05 21:31:00 +0000
60@@ -7,7 +7,6 @@
61 charmhelpers.contrib.charmhelpers
62 charmhelpers.contrib.charmsupport
63 charmhelpers.contrib.hahelpers
64- charmhelpers.contrib.jujugui
65 charmhelpers.contrib.network
66 charmhelpers.contrib.openstack
67 charmhelpers.contrib.peerstorage
68
69=== modified file 'docs/api/charmhelpers.core.rst'
70--- docs/api/charmhelpers.core.rst 2014-06-09 14:56:35 +0000
71+++ docs/api/charmhelpers.core.rst 2014-08-05 21:31:00 +0000
72@@ -25,6 +25,20 @@
73 :undoc-members:
74 :show-inheritance:
75
76+charmhelpers.core.services package
77+----------------------------------
78+
79+.. automodule:: charmhelpers.core.services.base
80+ :members:
81+ :undoc-members:
82+ :show-inheritance:
83+ :special-members: __init__
84+
85+.. automodule:: charmhelpers.core.services.helpers
86+ :members:
87+ :undoc-members:
88+ :show-inheritance:
89+
90
91 .. automodule:: charmhelpers.core
92 :members:
93
94=== modified file 'setup.py'
95--- setup.py 2014-06-09 15:23:32 +0000
96+++ setup.py 2014-08-05 21:31:00 +0000
97@@ -26,7 +26,6 @@
98 "charmhelpers.contrib.charmsupport",
99 "charmhelpers.contrib.saltstack",
100 "charmhelpers.contrib.hahelpers",
101- "charmhelpers.contrib.jujugui",
102 "charmhelpers.contrib.templating",
103 ],
104 'scripts': [

Subscribers

People subscribed via source and target branches