Merge lp:~tuxator/midori/profiles-win32 into lp:midori

Proposed by Paweł Forysiuk
Status: Merged
Approved by: Cris Dywan
Approved revision: 6333
Merged at revision: 6333
Proposed branch: lp:~tuxator/midori/profiles-win32
Merge into: lp:midori
Diff against target: 32 lines (+6/-0)
1 file modified
extensions/apps.vala (+6/-0)
To merge this branch: bzr merge lp:~tuxator/midori/profiles-win32
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+179551@code.launchpad.net

Commit message

win32: Hide gui for profiles in webapp manager, as they are currently broken on Windows

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

Looks sensible. Linux still works as before.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/apps.vala'
2--- extensions/apps.vala 2013-08-08 22:13:35 +0000
3+++ extensions/apps.vala 2013-08-09 22:51:39 +0000
4@@ -130,6 +130,8 @@
5 if (toolbar == null) {
6 toolbar = new Gtk.Toolbar ();
7
8+#if !HAVE_WIN32
9+ /* FIXME: Profiles are broken on win32 because of no multi instance support */
10 var profile = new Gtk.ToolButton.from_stock (Gtk.STOCK_ADD);
11 profile.label = _("New _Profile");
12 profile.tooltip_text = _("Creates a new, independant profile and a launcher");
13@@ -144,6 +146,7 @@
14 config, _("Midori (%s)").printf (uuid), this);
15 });
16 toolbar.insert (profile, -1);
17+#endif
18
19 var app = new Gtk.ToolButton.from_stock (Gtk.STOCK_ADD);
20 app.label = _("New _App");
21@@ -409,8 +412,11 @@
22 monitors = new GLib.List<GLib.FileMonitor> ();
23 app_folder = data_dir.get_child ("apps");
24 populate_apps.begin (app_folder);
25+ /* FIXME: Profiles are broken on win32 because of no multi instance support */
26 profile_folder = data_dir.get_child ("profiles");
27+#if !HAVE_WIN32
28 populate_apps.begin (profile_folder);
29+#endif
30 widgets = new GLib.List<Gtk.Widget> ();
31 foreach (var browser in app.get_browsers ())
32 browser_added (browser);

Subscribers

People subscribed via source and target branches

to all changes: