Merge lp:~tuxator/midori/colors into lp:midori
Proposed by
Paweł Forysiuk
Status: | Merged |
---|---|
Approved by: | Cris Dywan |
Approved revision: | 6174 |
Merged at revision: | 6177 |
Proposed branch: | lp:~tuxator/midori/colors |
Merge into: | lp:midori |
Diff against target: |
241 lines (+149/-66) 1 file modified
extensions/colorful-tabs.c (+149/-66) |
To merge this branch: | bzr merge lp:~tuxator/midori/colors |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Cris Dywan | Approve | ||
Review via email: mp+165714@code.launchpad.net |
Commit message
Split colorful tabs code into helper functions and add unit tests
To post a comment you must log in.
I love the refactoring.
As a follow-up thought, it might be nice to improve the big if () before the color function calls, it duplicates part of what the functions do and probably can be improved.