Merge lp:~tuxator/midori/adblock-parentheses into lp:midori

Proposed by Paweł Forysiuk
Status: Merged
Approved by: Cris Dywan
Approved revision: 6282
Merged at revision: 6284
Proposed branch: lp:~tuxator/midori/adblock-parentheses
Merge into: lp:midori
Diff against target: 23 lines (+7/-0)
1 file modified
extensions/adblock.c (+7/-0)
To merge this branch: bzr merge lp:~tuxator/midori/adblock-parentheses
Reviewer Review Type Date Requested Status
Cris Dywan Approve
Review via email: mp+177257@code.launchpad.net

Commit message

Escape parentheses in adblock_fixup_regexp

To post a comment you must log in.
Revision history for this message
Cris Dywan (kalikiana) wrote :

The change looks legit. The indentation of the case/ default statements is off, please correct that.

review: Needs Fixing
6282. By Paweł Forysiuk

Fix indentation

Revision history for this message
Cris Dywan (kalikiana) wrote :

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'extensions/adblock.c'
2--- extensions/adblock.c 2013-06-22 16:01:42 +0000
3+++ extensions/adblock.c 2013-07-28 20:21:26 +0000
4@@ -1153,6 +1153,12 @@
5 case ']':
6 g_string_append (str, "\\]");
7 break;
8+ case '(':
9+ g_string_append (str, "\\(");
10+ break;
11+ case ')':
12+ g_string_append (str, "\\)");
13+ break;
14 default:
15 g_string_append_printf (str,"%c", *src);
16 break;
17@@ -1779,6 +1785,7 @@
18 g_assert_cmpstr (adblock_parse_line (".*foo/bar"), ==, "..*foo/bar");
19 g_assert_cmpstr (adblock_parse_line ("http://bla.blub/*"), ==, "http://bla.blub/");
20 g_assert_cmpstr (adblock_parse_line ("bag?r[]=*cpa"), ==, "bag\\?r\\[\\]=.*cpa");
21+ g_assert_cmpstr (adblock_parse_line ("(facebookLike,"), ==, "\\(facebookLike,");
22 adblock_destroy_db ();
23 }
24

Subscribers

People subscribed via source and target branches

to all changes: