Merge lp:~ttx/nova/lp742706 into lp:~hudson-openstack/nova/trunk

[Thierry Carrez]

Add obviously-missing method that prevents an Hyper-V compute node from even
starting up

Add obviously-missing method that prevents an Hyper-V compute node from even
starting up... Two caveats:

1/ This is untested since I don't have an Hyper-V setup

2/ I wouldn't be surprised if there were other issues like this one
   further down the line

[Jay Pipes (jaypipes)]

gah, we *really* need functional tests in nova for all hypervisors we "support"...

[justinsb (justin-fathomdb)]

PyLint and/or other static analysis tools can catch this one as well.
 PyLint sometimes pops up a warning and sometimes it doesn't; not really
sure (yet) of when it does vs doesn't.

[justinsb (justin-fathomdb)]

PyLint did catch this one, sadly only a warning by default, so doesn't
appear in the errors list. We could probably promote it to be a error
instead of a warning.

nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'suspend' is abstract
in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method
'migrate_disk_and_power_off' is abstract in class 'ComputeDriver' but is not
overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'revert_resize' is
abstract in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'get_console_output'
is abstract in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'get_ajax_console' is
abstract in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method
'ensure_filtering_rules_for_instance' is abstract in class 'ComputeDriver'
but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'rescue' is abstract
in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'pause' is abstract in
class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'get_diagnostics' is
abstract in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'inject_file' is
abstract in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'unpause' is abstract
in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'finish_resize' is
abstract in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'resume' is abstract
in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method
'refresh_security_group_rules' is abstract in class 'ComputeDriver' but is
not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'snapshot_instance' is
abstract in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'unfilter_instance' is
abstract in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'inject_network_info'
is abstract in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'live_migration' is
abstract in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'reset_network' is
abstract in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method
'get_console_pool_info' is abstract in class 'ComputeDriver' but is not
overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method
'refresh_security_group_members' is abstract in class 'ComputeDriver' but is
not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'compare_cpu' is
abstract in class 'ComputeDriver' but is not overridden
nova/virt/hyperv.py:112: [W, HyperVConnection] Method 'get_host_ip_addr' is
abstract in class 'ComputeDriver' but is not overridden
no...

[Devin Carlen (devcamcar)]

treating this as a hotfix so approve

review: Approve

[termie (termie)]

lgtm

review: Approve

=== modified file 'nova/virt/hyperv.py'
--- nova/virt/hyperv.py	2011-03-24 08:56:06 +0000
+++ nova/virt/hyperv.py	2011-03-30 13:06:20 +0000
@@ -485,3 +485,7 @@
 
     def poll_rescued_instances(self, timeout):
         pass
+
+    def update_available_resource(self, ctxt, host):
+        """This method is supported only by libvirt."""
+        return