Merge lp:~ttx/nova/bexar-2011.1.1 into lp:nova/bexar

Proposed by Thierry Carrez
Status: Merged
Approved by: Soren Hansen
Approved revision: 648
Merged at revision: 650
Proposed branch: lp:~ttx/nova/bexar-2011.1.1
Merge into: lp:nova/bexar
Diff against target: 21 lines (+3/-3)
1 file modified
nova/version.py (+3/-3)
To merge this branch: bzr merge lp:~ttx/nova/bexar-2011.1.1
Reviewer Review Type Date Requested Status
Soren Hansen (community) Approve
Vish Ishaya (community) Approve
Devin Carlen (community) Approve
Review via email: mp+50297@code.launchpad.net

Commit message

Add support for micro-versions, and bump version number to 2011.1.1.

Description of the change

Add support for micro-versions, and bump version number to 2011.1.1.
Under the new simplified form it should probably not be forward-ported to Cactus.

To post a comment you must log in.
Revision history for this message
Soren Hansen (soren) wrote :

I think this is needlessly paranoid. I don't believe we intend to ever not have a micro version again, and the safe guards (the try/except blocks) are there to protect against changes to code in the very same file, which seems a bit pointless to me?

review: Needs Information
Revision history for this message
Thierry Carrez (ttx) wrote :

Simplified. You should know by now that I'm a bit paranoid.

lp:~ttx/nova/bexar-2011.1.1 updated
648. By Thierry Carrez

Simplify patch to only support version number with microversions, since this is a one-off

Revision history for this message
Devin Carlen (devcamcar) wrote :

lgtm

review: Approve
Revision history for this message
Vish Ishaya (vishvananda) wrote :

lgtm. Waiting for soren on marking approved

review: Approve
Revision history for this message
Soren Hansen (soren) wrote :

Let's do it.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'nova/version.py'
2--- nova/version.py 2011-02-02 10:16:00 +0000
3+++ nova/version.py 2011-02-18 12:44:08 +0000
4@@ -21,14 +21,14 @@
5 'revision_id': 'LOCALREVISION',
6 'revno': 0}
7
8-NOVA_VERSION = ['2011', '1']
9-YEAR, COUNT = NOVA_VERSION
10+NOVA_VERSION = ['2011', '1', '1']
11+YEAR, COUNT, MICRO = NOVA_VERSION
12
13 FINAL = True # This becomes true at Release Candidate time
14
15
16 def canonical_version_string():
17- return '.'.join([YEAR, COUNT])
18+ return '.'.join([YEAR, COUNT, MICRO])
19
20
21 def version_string():

Subscribers

People subscribed via source and target branches