Merge lp:~tsimonq2/livecd-rootfs/proper-task-names into lp:livecd-rootfs
Proposed by
Simon Quigley
on 2017-05-13
| Status: | Merged |
|---|---|
| Merged at revision: | 1479 |
| Proposed branch: | lp:~tsimonq2/livecd-rootfs/proper-task-names |
| Merge into: | lp:livecd-rootfs |
| Diff against target: |
23 lines (+5/-1) 1 file modified
live-build/auto/config (+5/-1) |
| To merge this branch: | bzr merge lp:~tsimonq2/livecd-rootfs/proper-task-names |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Simon Quigley (community) | Abstain on 2017-05-17 | ||
| Julien Lavergne (community) | 2017-05-13 | Needs Fixing on 2017-05-16 | |
| Ubuntu Core Development Team | 2017-05-13 | Pending | |
|
Review via email:
|
|||
Description of the Change
This corrects the image building for Lubuntu Next by specifying the correct tasks to use.
As far as I remember, both the lubuntu-live-qt and lubuntu-live-gtk tasks share a common lubuntu-live-share task that makes sure both top-level tasks have the required core dependencies.
Because Julien Lavergne (gilir) did most of the seed work, I would like his approval on this before it gets merged.
To post a comment you must log in.
lp:~tsimonq2/livecd-rootfs/proper-task-names
updated
on 2017-05-17
- 1480. By Simon Quigley on 2017-05-17
-
Update the file based on gilir's feedback
| Simon Quigley (tsimonq2) wrote : | # |
Hi Julien!
Thanks for the feedback. I just pushed an update to the branch fixing this. :)
review:
Resubmit

Thanks Simon for the work on this :-)
I added inline comments about the change. Also, you probably want to add the following block to lubuntu-next part of the code, to do the same that the main seed :
# The Lubuntu STRUCTURE file has "feature recommends" . Mirror this. recommends"
# no-follow-
export APT_OPTIONS="--yes --no-install-
;;