Merge lp:~tsimonq2/livecd-rootfs/proper-task-names into lp:livecd-rootfs

Proposed by Simon Quigley on 2017-05-13
Status: Merged
Merged at revision: 1479
Proposed branch: lp:~tsimonq2/livecd-rootfs/proper-task-names
Merge into: lp:livecd-rootfs
Diff against target: 23 lines (+5/-1)
1 file modified
live-build/auto/config (+5/-1)
To merge this branch: bzr merge lp:~tsimonq2/livecd-rootfs/proper-task-names
Reviewer Review Type Date Requested Status
Simon Quigley (community) Abstain on 2017-05-17
Julien Lavergne (community) 2017-05-13 Needs Fixing on 2017-05-16
Ubuntu Core Development Team 2017-05-13 Pending
Review via email: mp+324017@code.launchpad.net

Description of the Change

This corrects the image building for Lubuntu Next by specifying the correct tasks to use.

As far as I remember, both the lubuntu-live-qt and lubuntu-live-gtk tasks share a common lubuntu-live-share task that makes sure both top-level tasks have the required core dependencies.

Because Julien Lavergne (gilir) did most of the seed work, I would like his approval on this before it gets merged.

To post a comment you must log in.
Julien Lavergne (gilir) wrote :

Thanks Simon for the work on this :-)

I added inline comments about the change. Also, you probably want to add the following block to lubuntu-next part of the code, to do the same that the main seed :

# The Lubuntu STRUCTURE file has "feature
# no-follow-recommends". Mirror this.
export APT_OPTIONS="--yes --no-install-recommends"
;;

review: Needs Fixing
1480. By Simon Quigley on 2017-05-17

Update the file based on gilir's feedback

Simon Quigley (tsimonq2) wrote :

Hi Julien!

Thanks for the feedback. I just pushed an update to the branch fixing this. :)

review: Resubmit
Simon Quigley (tsimonq2) wrote :

Accident /o\

review: Abstain

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'live-build/auto/config'
2--- live-build/auto/config 2017-04-28 21:48:46 +0000
3+++ live-build/auto/config 2017-05-17 01:09:48 +0000
4@@ -348,7 +348,7 @@
5
6 lubuntu-next)
7 add_task install minimal standard lubuntu-qt-desktop
8- LIVE_TASK='lubuntu-next-live'
9+ LIVE_TASK='lubuntu-live-qt'
10 case $ARCH in
11 amd64) add_package live linux-signed-generic ;;
12 esac
13@@ -356,6 +356,10 @@
14 case $ARCH in
15 amd64|i386) KERNEL_FLAVOURS=generic ;;
16 esac
17+
18+ # The Lubuntu STRUCTURE file has "feature
19+ # no-follow-recommends". Mirror this.
20+ export APT_OPTIONS="--yes --no-install-recommends"
21 ;;
22
23 ubuntu-gnome)

Subscribers

People subscribed via source and target branches