Merge lp:~tsimonq2/debian-cd/lubuntu-cosmic-changes into lp:~ubuntu-cdimage/debian-cd/ubun3
Proposed by
Simon Quigley
on 2018-05-17
Status: | Merged |
---|---|
Merged at revision: | 1995 |
Proposed branch: | lp:~tsimonq2/debian-cd/lubuntu-cosmic-changes |
Merge into: | lp:~ubuntu-cdimage/debian-cd/ubun3 |
Diff against target: |
57 lines (+28/-12) 1 file modified
tools/boot/cosmic/boot-amd64 (+28/-12) |
To merge this branch: | bzr merge lp:~tsimonq2/debian-cd/lubuntu-cosmic-changes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Langasek | Needs Fixing on 2018-07-12 | ||
Adam Conrad (community) | 2018-05-17 | Needs Fixing on 2018-05-22 | |
Review via email:
|
This proposal supersedes a proposal from 2018-05-17.
Description of the change
On startup, Lubuntu wants to be the same as Kubuntu, in that "Try Lubuntu before installing" and "Install Lubuntu" are removed in favor of "Start Lubuntu".
To post a comment you must log in.
lp:~tsimonq2/debian-cd/lubuntu-cosmic-changes
updated
on 2018-05-18
- 1994. By Simon Quigley on 2018-05-18
-
Rework 419ish to use case rather than || || ||.
Simon Quigley (tsimonq2) wrote : | # |
.
review:
Needs Fixing
lp:~tsimonq2/debian-cd/lubuntu-cosmic-changes
updated
on 2018-05-21
- 1995. By Simon Quigley on 2018-05-21
-
Add kubuntu-plasma5 back.
review:
Needs Fixing
lp:~tsimonq2/debian-cd/lubuntu-cosmic-changes
updated
on 2018-07-05
- 1996. By Simon Quigley on 2018-05-22
-
Some more adjustments from Adam's comments.
- 1997. By Simon Quigley on 2018-07-05
-
Make the code reflect the variable name.
lp:~tsimonq2/debian-cd/lubuntu-cosmic-changes
updated
on 2018-07-12
- 1998. By Simon Quigley on 2018-07-12
-
Make ubuntu-mid work.
Simon Quigley (tsimonq2) wrote : | # |
I did that, but made the ubuntu-mid case identical to the catch-all case with the exception of setting that env var.
Thanks Steve!
Would you mind switching these terrible if || || || constructions into case statements as part of this?