Merge ~tsimonq2/debian-cd/+git/ubuntu:no-oem-entries into ~ubuntu-cdimage/debian-cd/+git/ubuntu:main

Proposed by Simon Quigley
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 5277afe97517ff9f2e711c02a481db333c4eba7d
Merged at revision: 5277afe97517ff9f2e711c02a481db333c4eba7d
Proposed branch: ~tsimonq2/debian-cd/+git/ubuntu:no-oem-entries
Merge into: ~ubuntu-cdimage/debian-cd/+git/ubuntu:main
Diff against target: 31 lines (+2/-11)
1 file modified
tools/boot/noble/common.sh (+2/-11)
Reviewer Review Type Date Requested Status
Joshua Peisach (community) Approve
Sean Davis (community) Approve
Martin Wimpress  (community) Approve
Łukasz Zemczak Approve
Review via email: mp+464881@code.launchpad.net

Description of the change

Related to bug 2048473 and bug 2063291.

In the live ISOs for Ubuntu MATE, Ubuntu Cinnamon, Ubuntu Kylin, and Xubuntu, there is a boot entry for an OEM mode. Unfortunately, that OEM mode does not exist yet for the main Ubuntu Desktop Installer. Remove the appropriate entries for those four flavors, to be re-added once that functionality exists again.

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) :
review: Approve
Revision history for this message
Martin Wimpress  (flexiondotorg) :
review: Approve
Revision history for this message
handsome_feng (feng-kylin) wrote :

Can we respin the Ubuntu Kylin ISO after this fix released?

Thanks!

Revision history for this message
Sean Davis (bluesabre) wrote :

Ack for Xubuntu

review: Approve
Revision history for this message
Joshua Peisach (itzswirlz) wrote :

Good for ubuntu cinnamon

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tools/boot/noble/common.sh b/tools/boot/noble/common.sh
2index c1f6d7a..1fed0d3 100644
3--- a/tools/boot/noble/common.sh
4+++ b/tools/boot/noble/common.sh
5@@ -1,24 +1,15 @@
6 # encode the right CD kernel parameteres, for every project
7 default_kernel_params() {
8 case $PROJECT in
9- ubuntu|edubuntu|ubuntustudio|ubuntu-budgie|kubuntu|ubuntu-unity)
10+ ubuntu|edubuntu|ubuntustudio|ubuntu-budgie|kubuntu|ubuntu-unity|ubuntucinnamon|xubuntu|ubuntu-mate)
11 KERNEL_PARAMS="${KERNEL_PARAMS:+$KERNEL_PARAMS } --- quiet splash"
12 ;;
13 ubuntukylin)
14- KERNEL_PARAMS="${KERNEL_PARAMS:+$KERNEL_PARAMS }file=/cdrom/preseed/ubuntu.seed locale=zh_CN keyboard-configuration/layoutcode?=cn maybe-ubiquity quiet splash --- "
15- ;;
16- ubuntucinnamon)
17- KERNEL_PARAMS="${KERNEL_PARAMS:+$KERNEL_PARAMS }file=/cdrom/preseed/ubuntucinnamon.seed maybe-ubiquity quiet splash --- "
18+ KERNEL_PARAMS="${KERNEL_PARAMS:+$KERNEL_PARAMS }file=/cdrom/preseed/ubuntu.seed locale=zh_CN keyboard-configuration/layoutcode?=cn quiet splash --- "
19 ;;
20 lubuntu)
21 KERNEL_PARAMS="${KERNEL_PARAMS:+$KERNEL_PARAMS }file=/cdrom/preseed/lubuntu.seed quiet splash --- "
22 ;;
23- xubuntu)
24- KERNEL_PARAMS="${KERNEL_PARAMS:+$KERNEL_PARAMS }file=/cdrom/preseed/xubuntu.seed maybe-ubiquity quiet splash --- "
25- ;;
26- ubuntu-mate)
27- KERNEL_PARAMS="${KERNEL_PARAMS:+$KERNEL_PARAMS }file=/cdrom/preseed/ubuntu-mate.seed maybe-ubiquity quiet splash --- "
28- ;;
29 ubuntu-server)
30 KERNEL_PARAMS="${KERNEL_PARAMS:+$KERNEL_PARAMS } ---"
31 ;;

Subscribers

People subscribed via source and target branches