~tshinn/snap-store-proxy-charm:readme_registration_bundle

Branch merges

Propose for merging

Merged into snap-store-proxy-charm:master

William Grant: Approve (code) on 2022-04-06

Diff: 15 lines (+2/-2)

1 file modified

README.md (+2/-2)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

a9c1fc4... by Tong Shinn on 2022-04-06

Update README to be more clear on how registration_bundle works.

95de79a... by Wouter van Bommel on 2022-04-04

Sync the documentation with how it is added to discourse.charmhub.io

Added a docs tag to metadata.yaml, now it is known

Merged from https://code.launchpad.net/~woutervb/snap-store-proxy-charm/+git/snap-store-proxy-charm/+merge/418000

63668cf... by Wouter van Bommel on 2022-04-04

Fix too long line length

c7e86b2... by Wouter van Bommel on 2022-03-31

Added a reference to a binary python package

With the latest cryptography packing will fail, as some of the
dependencies can't be build and added debian packages doesn't seem
possible.

Limited the supported architectures to only amd64

6679949... by Wouter van Bommel on 2022-03-30

Updated documentation to reflect https://discource.charmhub.io

f940f83... by Wouter van Bommel on 2022-03-28

Add handling of tls certificates

When using certificates, we should:
 * Validate that the correct name is mentioned in the certificate
 * Validate that the key and certificate match
 * That we open the correct port
 * That we close the correct port
 * Validate that the correct encoding is used

We explicitly don't check the certificate chain or CA, as that is
something that is up to the endpoint (snapd) to validate and with custom
certificates there is a change that we don't have all the needed
information.

Merged from https://code.launchpad.net/~woutervb/snap-store-proxy-charm/+git/snap-store-proxy-charm/+merge/417457

a854da0... by Wouter van Bommel on 2022-03-28

Reworked error handling in handle_certificate

As suggested in review feedback error handling could be simplified, have
done that now and code looks cleaner and is more consistend.

e999f3a... by Wouter van Bommel on 2022-03-22

Add handling of tls certificates

When using certificates, we should:
* Validate that the correct name is mentioned in the certificate
* Validate that the key and certificate match
* That we open the correct port
* That we close the correct port
* Validate that the correct encoding is used

We explicitly don't check the certificate chain or CA, as that is
something that is up to the endpoint (snapd) to validate and with custom
certificates there is a change that we don't have all the needed
information.

0c7d4c1... by Wouter van Bommel on 2022-03-20

Remove base64 references for registration_bundle

Since the tools `store-admin` will already output the data in the
correct format for juju config to consume, there is no need for the end
user to do any manipulation. So the documentation is updated to reflect
this.

Merged from https://code.launchpad.net/~woutervb/snap-store-proxy-charm/+git/snap-store-proxy-charm/+merge/416925

3da1eea... by Wouter van Bommel on 2022-03-16

Remove base64 references for registration_bundle

Since the tools `store-admin` will already output the data in the
correct format for juju config to consume, there is no need for the end
user to do any manipulation. So the documentation is updated to reflect
this.