Merge lp:~tsarev/percona-server/release-5.1.57-12.8-794774 into lp:~percona-dev/percona-server/5.5.11

Proposed by Oleg Tsarev
Status: Superseded
Proposed branch: lp:~tsarev/percona-server/release-5.1.57-12.8-794774
Merge into: lp:~percona-dev/percona-server/5.5.11
Prerequisite: lp:~tsarev/percona-server/release-5.1.57-12.8-794776
Diff against target: 27 lines (+17/-0) (has conflicts)
1 file modified
profiling_slow.patch (+17/-0)
Conflict adding file COPYING.innodb-deadlock-count-patch.  Moved existing file to COPYING.innodb-deadlock-count-patch.moved.
Conflict adding file COPYING.show_temp_51.  Moved existing file to COPYING.show_temp_51.moved.
Conflict adding file Makefile.  Moved existing file to Makefile.moved.
Conflict adding file bug580324.patch.  Moved existing file to bug580324.patch.moved.
Conflict adding file control_online_alter_index.patch.  Moved existing file to control_online_alter_index.patch.moved.
Conflict adding file error_pad.patch.  Moved existing file to error_pad.patch.moved.
Conflict adding file innodb_admin_command_base.patch.  Moved existing file to innodb_admin_command_base.patch.moved.
Conflict adding file innodb_buffer_pool_shm.patch.  Moved existing file to innodb_buffer_pool_shm.patch.moved.
Conflict adding file innodb_bug60788.patch.  Moved existing file to innodb_bug60788.patch.moved.
Conflict adding file innodb_deadlock_count.patch.  Moved existing file to innodb_deadlock_count.patch.moved.
Conflict adding file innodb_dict_size_limit.patch.  Moved existing file to innodb_dict_size_limit.patch.moved.
Conflict adding file innodb_expand_fast_index_creation.patch.  Moved existing file to innodb_expand_fast_index_creation.patch.moved.
Conflict adding file innodb_expand_import.patch.  Moved existing file to innodb_expand_import.patch.moved.
Conflict adding file innodb_extend_slow.patch.  Moved existing file to innodb_extend_slow.patch.moved.
Conflict adding file innodb_extra_rseg.patch.  Moved existing file to innodb_extra_rseg.patch.moved.
Conflict adding file innodb_fast_checksum.patch.  Moved existing file to innodb_fast_checksum.patch.moved.
Conflict adding file innodb_files_extend.patch.  Moved existing file to innodb_files_extend.patch.moved.
Conflict adding file innodb_fix_misc.patch.  Moved existing file to innodb_fix_misc.patch.moved.
Conflict adding file innodb_io_patches.patch.  Moved existing file to innodb_io_patches.patch.moved.
Conflict adding file innodb_lru_dump_restore.patch.  Moved existing file to innodb_lru_dump_restore.patch.moved.
Conflict adding file innodb_opt_lru_count.patch.  Moved existing file to innodb_opt_lru_count.patch.moved.
Conflict adding file innodb_overwrite_relay_log_info.patch.  Moved existing file to innodb_overwrite_relay_log_info.patch.moved.
Conflict adding file innodb_pass_corrupt_table.patch.  Moved existing file to innodb_pass_corrupt_table.patch.moved.
Conflict adding file innodb_recovery_patches.patch.  Moved existing file to innodb_recovery_patches.patch.moved.
Conflict adding file innodb_separate_doublewrite.patch.  Moved existing file to innodb_separate_doublewrite.patch.moved.
Conflict adding file innodb_show_lock_name.patch.  Moved existing file to innodb_show_lock_name.patch.moved.
Conflict adding file innodb_show_status.patch.  Moved existing file to innodb_show_status.patch.moved.
Conflict adding file innodb_show_sys_tables.patch.  Moved existing file to innodb_show_sys_tables.patch.moved.
Conflict adding file innodb_split_buf_pool_mutex.patch.  Moved existing file to innodb_split_buf_pool_mutex.patch.moved.
Conflict adding file innodb_stats.patch.  Moved existing file to innodb_stats.patch.moved.
Conflict adding file innodb_thread_concurrency_timer_based.patch.  Moved existing file to innodb_thread_concurrency_timer_based.patch.moved.
Conflict adding file install_tests.sh.  Moved existing file to install_tests.sh.moved.
Conflict adding file log_connection_error.patch.  Moved existing file to log_connection_error.patch.moved.
Conflict adding file lrusort.py.  Moved existing file to lrusort.py.moved.
Conflict adding file microsec_process.patch.  Moved existing file to microsec_process.patch.moved.
Conflict adding file mysql-test.diff.  Moved existing file to mysql-test.diff.moved.
Conflict adding file mysql-test.  Moved existing file to mysql-test.moved.
Conflict adding file mysql_dump_ignore_ct.patch.  Moved existing file to mysql_dump_ignore_ct.patch.moved.
Conflict adding file mysql_remove_eol_carret.patch.  Moved existing file to mysql_remove_eol_carret.patch.moved.
Conflict adding file normalize_patches.sh.  Moved existing file to normalize_patches.sh.moved.
Conflict adding file optimizer_fix.patch.  Moved existing file to optimizer_fix.patch.moved.
Conflict adding file query_cache_enhance.patch.  Moved existing file to query_cache_enhance.patch.moved.
Conflict adding file regenerate_patch.sh.  Moved existing file to regenerate_patch.sh.moved.
Conflict adding file remove_fcntl_excessive_calls.patch.  Moved existing file to remove_fcntl_excessive_calls.patch.moved.
Conflict adding file series.  Moved existing file to series.moved.
Conflict adding file show_slave_status_nolock.patch.  Moved existing file to show_slave_status_nolock.patch.moved.
Conflict adding file slow_extended.patch.  Moved existing file to slow_extended.patch.moved.
Conflict adding file sql_no_fcache.patch.  Moved existing file to sql_no_fcache.patch.moved.
Conflict adding file userstat.patch.  Moved existing file to userstat.patch.moved.
To merge this branch: bzr merge lp:~tsarev/percona-server/release-5.1.57-12.8-794774
Reviewer Review Type Date Requested Status
Stewart Smith (community) Needs Fixing
Review via email: mp+63941@code.launchpad.net

This proposal has been superseded by a proposal from 2011-06-20.

Description of the change

The reason of bug #794774: patch profiling_slow.patch adds option "log_slow_verbosity" with value "profiling_use_getrusage".
This option enable/disable call "getrusage", but doesn't check status when uses variable changed by "getrusage".
As result valgrind show warning "potential use of uninitialized value".
Now I check status before access to changed variables.
This is actual for tests:
 * main.profiling
 * main.show_profile

To post a comment you must log in.
Revision history for this message
Stewart Smith (stewart) wrote :

looks like wrong branch proposed. please resubmit against main lp:percona-server and/or lp:percona-server/5.1

review: Needs Fixing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'profiling_slow.patch'
2--- profiling_slow.patch 2011-06-09 00:04:54 +0000
3+++ profiling_slow.patch 2011-06-09 00:04:57 +0000
4@@ -327,6 +327,23 @@
5 /**
6 Fill the information schema table, "query_profile", as defined in show.cc .
7 There are two ways to get to this function: Selecting from the information
8+@@ -575,6 +702,8 @@
9+
10+ #ifdef HAVE_GETRUSAGE
11+
12++ if (enabled_getrusage())
13++ {
14+ my_decimal cpu_utime_decimal, cpu_stime_decimal;
15+
16+ double2my_decimal(E_DEC_FATAL_ERROR,
17+@@ -645,6 +774,7 @@
18+ table->field[14]->store((uint32)(entry->rusage.ru_nswap -
19+ previous->rusage.ru_nswap), true);
20+ table->field[14]->set_notnull();
21++ }
22+ #else
23+ /* TODO: Add swap info for non-BSD systems */
24+ #endif
25 diff -ruN a/sql/sql_profile.h b/sql/sql_profile.h
26 --- a/sql/sql_profile.h 2010-10-12 00:34:33.000000000 +0400
27 +++ b/sql/sql_profile.h 2010-11-25 15:54:48.000000000 +0300

Subscribers

People subscribed via source and target branches