Merge lp:~tsarev/percona-server/12952 into lp:percona-server/5.1
Proposed by
Oleg Tsarev
Status: | Superseded |
---|---|
Proposed branch: | lp:~tsarev/percona-server/12952 |
Merge into: | lp:percona-server/5.1 |
Diff against target: |
364 lines (+250/-68) 1 file modified
patches/show_slave_status_nolock.patch (+250/-68) |
To merge this branch: | bzr merge lp:~tsarev/percona-server/12952 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alexey Kopytov | Pending | ||
Oleg Tsarev | Pending | ||
Review via email: mp+75705@code.launchpad.net |
This proposal supersedes a proposal from 2011-09-16.
This proposal has been superseded by a proposal from 2011-09-16.
Description of the change
Add test-case for bug #851011: SHOW SLAVE STATUS NOLOCK acquire lock on
sql/slave.cc: 1650
pthread_
Fix: wrap mutex lock/unlock by check to \"UNLOCK\" statement
Issue number: #12952.
To post a comment you must log in.
I don't see a point in reviewing a test case separately from the fix. For example, is the .result file from the test with the bug fixed or not?
And I still don't see a detailed description of the problem we are trying to fix, which complicates reviewing the test case even further. No, the reported bug does not help much either. "SHOW SLAVE STATUS NOLOCK acquire lock on some mutex" sounds like the problem is not quite clear.