Merge ~troyanov/maas:backport-a467133-3.5 into maas:3.5

[Anton Troyanov]

fix: node & current_script_set database integrity

Due to a bug in Django [0] there was no foreign key constraint in the database.
So MAAS had nodes pointing to the current commissioning, installation, testing
and release script set that might have been removed already.

[0] https://code.djangoproject.com/ticket/4930

Resolves LP:2056330

(cherry picked from commit a4671339a2fb5a1124fc2382e208d2518267f645)

[Anton Troyanov (troyanov)]

review: Approve

[MAAS Lander (maas-lander)]

UNIT TESTS
-b backport-a467133-3.5 lp:~troyanov/maas/+git/maas into -b 3.5 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: bc3812b4acad8f0d72e497f11fb41efff5a2653e

review: Approve

diff --git a/src/maasserver/migrations/maasserver/0320_current_script_set_foreign_keys_drop_indexes.py b/src/maasserver/migrations/maasserver/0320_current_script_set_foreign_keys_drop_indexes.py
new file mode 100644
index 0000000..a13678c
--- /dev/null
+++ b/src/maasserver/migrations/maasserver/0320_current_script_set_foreign_keys_drop_indexes.py
@@ -0,0 +1,48 @@
+# Generated by Django 3.2.12 on 2024-03-18 15:11
+
+from django.db import migrations, models
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("maasserver", "0319_merge_0304_and_0318"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="node",
+            name="current_commissioning_script_set",
+            field=models.IntegerField(
+                blank=True,
+                db_column="current_commissioning_script_set_id",
+                null=True,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="node",
+            name="current_installation_script_set",
+            field=models.IntegerField(
+                blank=True,
+                db_column="current_installation_script_set_id",
+                null=True,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="node",
+            name="current_testing_script_set",
+            field=models.IntegerField(
+                blank=True,
+                db_column="current_testing_script_set_id",
+                null=True,
+            ),
+        ),
+        migrations.AlterField(
+            model_name="node",
+            name="current_release_script_set",
+            field=models.IntegerField(
+                blank=True,
+                db_column="current_release_script_set_id",
+                null=True,
+            ),
+        ),
+    ]
diff --git a/src/maasserver/migrations/maasserver/0321_current_script_set_foreign_keys_cleanup.py b/src/maasserver/migrations/maasserver/0321_current_script_set_foreign_keys_cleanup.py
new file mode 100644
index 0000000..a8800d9
--- /dev/null
+++ b/src/maasserver/migrations/maasserver/0321_current_script_set_foreign_keys_cleanup.py
@@ -0,0 +1,41 @@
+# Generated by Django 3.2.12 on 2024-03-18 15:12
+
+from django.db import migrations, models
+
+
+def clean_up_missing_scriptset_links(apps, schema_editor):
+    """Clean up current_foo_script_set_id that have been removed.
+
+    A node points to the current commissioning, installation, testing
+    and release script set. But since there was no foreign key constraint
+    in the database, the corresponding script set might have been removed
+    already.
+    """
+    ScriptSet = apps.get_model("maasserver", "ScriptSet")
+    Node = apps.get_model("maasserver", "Node")
+    Node.objects.exclude(
+        current_testing_script_set__isnull=False,
+        current_testing_script_set__in=ScriptSet.objects.all(),
+    ).update(current_testing_script_set=None)
+    Node.objects.exclude(
+        current_commissioning_script_set__isnull=False,
+        current_commissioning_script_set__in=ScriptSet.objects.all(),
+    ).update(current_commissioning_script_set=None)
+    Node.objects.exclude(
+        current_installation_script_set__isnull=False,
+        current_installation_script_set__in=ScriptSet.objects.all(),
+    ).update(current_installation_script_set=None)
+    Node.objects.exclude(
+        current_release_script_set__isnull=False,
+        current_release_script_set__in=ScriptSet.objects.all(),
+    ).update(current_release_script_set=None)
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("maasserver", "0320_current_script_set_foreign_keys_drop_indexes"),
+    ]
+
+    operations = [
+        migrations.RunPython(clean_up_missing_scriptset_links),
+    ]
diff --git a/src/maasserver/migrations/maasserver/0322_current_script_set_foreign_keys_readd.py b/src/maasserver/migrations/maasserver/0322_current_script_set_foreign_keys_readd.py
new file mode 100644
index 0000000..b9327c9
--- /dev/null
+++ b/src/maasserver/migrations/maasserver/0322_current_script_set_foreign_keys_readd.py
@@ -0,0 +1,57 @@
+# Generated by Django 3.2.12 on 2024-03-18 15:12
+
+from django.db import migrations, models
+import django.db.models.deletion
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("maasserver", "0321_current_script_set_foreign_keys_cleanup"),
+    ]
+
+    operations = [
+        migrations.AlterField(
+            model_name="node",
+            name="current_commissioning_script_set",
+            field=models.ForeignKey(
+                blank=True,
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                related_name="+",
+                to="maasserver.scriptset",
+            ),
+        ),
+        migrations.AlterField(
+            model_name="node",
+            name="current_installation_script_set",
+            field=models.ForeignKey(
+                blank=True,
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                related_name="+",
+                to="maasserver.scriptset",
+            ),
+        ),
+        migrations.AlterField(
+            model_name="node",
+            name="current_testing_script_set",
+            field=models.ForeignKey(
+                blank=True,
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                related_name="+",
+                to="maasserver.scriptset",
+            ),
+        ),
+        migrations.AlterField(
+            model_name="node",
+            name="current_release_script_set",
+            field=models.ForeignKey(
+                blank=True,
+                null=True,
+                on_delete=django.db.models.deletion.SET_NULL,
+                related_name="+",
+                to="maasserver.scriptset",
+            ),
+        ),
+    ]