MAAS

Merge ~troyanov/maas:backport-testtools-fix-3.3 into maas:3.3

  1. Git
  2. lp:~troyanov/maas
  3. backport-testtools-fix-3.3
  4. Merge into 3.3
Proposed by Anton Troyanov
Status: Merged
Approved by: Anton Troyanov
Approved revision: fde2475c8726901b7804aa5c177440fae2c2f113
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~troyanov/maas:backport-testtools-fix-3.3
Merge into: maas:3.3
Diff against target: 11 lines (+1/-0)
1 file modified
requirements-dev.txt (+1/-0)
Reviewer Review Type Date Requested Status
MAAS Lander Approve
Anton Troyanov Approve
Review via email: mp+438931@code.launchpad.net

Commit message

fix: set explicit testtools version

testtools 2.6.0 has a breaking change [1] that leads to an error:

    AttributeError: module 'email' has no attribute 'message'

[1]: https://github.com/testing-cabal/testtools/commit/b4bcd3c3d1964352d5f51def08629114057541a8

(cherry picked from commit f08e136c52d5dab55e73da9f9e65042bb28ad612)

To post a comment you must log in.
Revision history for this message
Anton Troyanov (troyanov) wrote :

Self approve backport to 3.3

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b backport-testtools-fix-3.3 lp:~troyanov/maas/+git/maas into -b 3.3 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: fde2475c8726901b7804aa5c177440fae2c2f113

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/requirements-dev.txt b/requirements-dev.txt
2index 0b72d0f..443d70a 100644
3--- a/requirements-dev.txt
4+++ b/requirements-dev.txt
5@@ -9,5 +9,6 @@ pytest-xdist==2.5.0
6 python-subunit==1.4.0
7 testresources==2.0.1
8 testscenarios==0.5.0
9+testtools==2.5.0
10 # Install MAAS itself in editable mode
11 -e .

Subscribers

People subscribed via source and target branches