Merge lp:~trojan295/scratch/bugfix1329550 into lp:~elementary-apps/scratch/scratch
Proposed by
Damian Czaja
Status: | Merged | ||||
---|---|---|---|---|---|
Merged at revision: | 1470 | ||||
Proposed branch: | lp:~trojan295/scratch/bugfix1329550 | ||||
Merge into: | lp:~elementary-apps/scratch/scratch | ||||
Diff against target: |
198 lines (+29/-39) 4 files modified
data/scratch-text-editor.desktop (+4/-0) src/MainWindow.vala (+4/-3) src/Scratch.vala (+20/-36) src/config.vala.cmake (+1/-0) |
||||
To merge this branch: | bzr merge lp:~trojan295/scratch/bugfix1329550 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
elementary Apps team | Pending | ||
Review via email: mp+241317@code.launchpad.net |
Description of the change
Moved the About dialog to quicklist.
There were some problems with Scratch. The argument '--about' was unknown, even through class ScratchApp inherited from Granite.
To be honest, I'm not sure what for was that code in the main(). I cannot recognize any difference after removing it. Someone has to check that.
To post a comment you must log in.
I am not qualified to review this code changes but I can tell you that you need to add "About Scratch" as a string so it's present in the translation domain.
Like this: http:// bazaar. launchpad. net/~elementary -apps/snap- elementary/ snap/view/ head:/src/ Snap.vala# L35