Merge lp:~tribaal/livecd-rootfs/xenial-proposed-vagrant-user-changes into lp:~ubuntu-core-dev/livecd-rootfs/xenial-proposed

[Chris Glass]

This branch is a backport to Xenial of the changes already in Artful/Bionic with regard to the default user layout of our produced vagrant box.

The equivalent trunk (at the time) commit is https://bazaar.launchpad.net/~ubuntu-core-dev/livecd-rootfs/trunk/revision/1504

Some more information (including the SRU template) can be found in the linked bug.

[Philip Roche (philroche)]

Changes LGTM.

review: Approve

[David Britton (dpb)]

Inline comment about dropping the ubuntu user.

review: Needs Information

[Chris Glass (tribaal)]

Answered inline - the ubuntu user is not being dropped.

[David Britton (dpb)]

review: Approve

[lp:~tribaal/livecd-rootfs/xenial-proposed-vagrant-user-changes]

1451. By Chris Glass on 2017-12-13

debian/changelog should target UNRELEASED until actually released.

1452. By Chris Glass on 2017-12-13

Made changelog entry more explicit.

[Łukasz Zemczak (sil2100)]

Dreadful. +1

review: Approve (non-cpc)

=== modified file 'debian/changelog'
--- debian/changelog	2017-12-06 10:34:36 +0000
+++ debian/changelog	2017-12-13 16:55:38 +0000
@@ -1,3 +1,10 @@
+livecd-rootfs (2.408.26) UNRELEASED; urgency=medium
+
+  * Added a "vagrant" user to the vagrant image in addition to the "ubuntu"
+    user, in accordance with the vagrant community's expectations (LP: #1569237)
+
+ -- Christopher Glass (Ubuntu) <[e-mail]>  Thu, 07 Dec 2017 14:00:59 +0100
+
 livecd-rootfs (2.408.25) xenial; urgency=medium
 
   * Sort and list dependencies nicely

=== modified file 'live-build/ubuntu-cpc/hooks/042-vagrant.binary'
--- live-build/ubuntu-cpc/hooks/042-vagrant.binary	2017-12-05 21:40:35 +0000
+++ live-build/ubuntu-cpc/hooks/042-vagrant.binary	2017-12-13 16:55:38 +0000
@@ -58,6 +58,29 @@
 # avoid pulling into a cloud image.
 chroot ${mount_d} apt-get install --no-install-recommends -y virtualbox-guest-utils
 chroot ${mount_d} apt-get clean
+
+# Create and setup users inside the image.
+# Vagrant users expect a "vagrant" user with a "vagrant" username.
+# See https://www.vagrantup.com/docs/boxes/base.html
+# Note: We decided NOT to allow root login with a default password.
+chroot ${mount_d} adduser vagrant
+echo "vagrant:vagrant" | chroot ${mount_d} chpasswd
+
+# The vagrant user should have passwordless sudo.
+cat << EOF > ${mount_d}/etc/sudoers.d/vagrant
+vagrant ALL=(ALL) NOPASSWD:ALL
+EOF
+
+# Add the insecure vagrant pubkey to the vagrant user, as is expected by the
+# vagrant ecosystem (https://www.vagrantup.com/docs/boxes/base.html)
+chroot ${mount_d} chmod 0440 /etc/sudoers.d/vagrant
+chroot ${mount_d} mkdir -p /home/vagrant/.ssh
+cat << EOF > ${mount_d}/home/vagrant/.ssh/authorized_keys
+ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEA6NF8iallvQVp22WDkTkyrtvp9eWW6A8YVr+kz4TjGYe7gHzIw+niNltGEFHzD8+v1I2YJ6oXevct1YeS0o9HZyN1Q9qgCgzUFtdOKLv6IedplqoPkcmF0aYet2PkEDo3MlTBckFXPITAMzF8dJSIFo9D8HfdOV0IAdx4O7PtixWKn5y2hMNG0zQPyUecp4pzC6kivAIhyfHilFR61RGL+GPXQ2MWZWFYbAGjyiYJnAmCP3NOTd0jMZEnDkbUvxhMmBYSdETk1rRgm+R4LOzFUGaHqHDLKLX+FIPKcF96hrucXzcWyLbIbEgE98OHlnVYCzRdK8jlqm8tehUc9c9WhQ== vagrant insecure public key
+EOF
+chroot ${mount_d} chown -R vagrant:vagrant /home/vagrant/.ssh
+chroot ${mount_d} chmod 700 /home/vagrant/.ssh
+
 umount_disk_image "$mount_d"
 rmdir "$mount_d"
 
@@ -71,12 +94,6 @@
 vmdk_f="${box_d}/${prefix}.vmdk"
 create_vmdk ${derivative_img} ${vmdk_f}
 
-# Vagrant needs a base user. We either inject the well-known SSH key
-# or use password authentication. Both are ugly. So we'll use a password
-# and make it random. This obviously is insecure...but at least its
-# better than the alternatives.
-ubuntu_user_pass=$(openssl rand -hex 12)
-
 ####################################
 # Create the ConfigDrive
 # This is a cloud-init piece that instructs cloud-init to configure
@@ -89,9 +106,6 @@
 # except via local host.
 cat > ${seed_d}/user-data <<END
 #cloud-config
-password: ${ubuntu_user_pass}
-chpasswd: { expire: False }
-ssh_pwauth: True
 manage_etc_hosts: localhost
 END
 
@@ -132,8 +146,6 @@
 
 Vagrant.configure("2") do |config|
   config.vm.base_mac = "${macaddr}"
-  config.ssh.username = "ubuntu"
-  config.ssh.password = "${ubuntu_user_pass}"
 
   config.vm.provider "virtualbox" do |vb|
      vb.customize [ "modifyvm", :id, "--uart1", "0x3F8", "4" ]