Merge lp:~tribaal/landscape-client/remove-mocker-test-updatemanager into lp:~landscape/landscape-client/trunk

Proposed by Chris Glass
Status: Merged
Approved by: Chris Glass
Approved revision: 843
Merged at revision: 859
Proposed branch: lp:~tribaal/landscape-client/remove-mocker-test-updatemanager
Merge into: lp:~landscape/landscape-client/trunk
Diff against target: 27 lines (+6/-5)
1 file modified
landscape/monitor/tests/test_updatemanager.py (+6/-5)
To merge this branch: bzr merge lp:~tribaal/landscape-client/remove-mocker-test-updatemanager
Reviewer Review Type Date Requested Status
Bogdana Vereha (community) Approve
🤖 Landscape Builder test results Approve
Chad Smith Approve
Review via email: mp+297528@code.launchpad.net

Commit message

s/mocker/mock/

Description of the change

s/mocker/mock/

Testing instructions:

To post a comment you must log in.
Revision history for this message
Chad Smith (chad.smith) wrote :

+1. Keep that train going. Chugga Chugga choo-choo.

review: Approve
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :
review: Approve (test results)
Revision history for this message
Bogdana Vereha (bogdana) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'landscape/monitor/tests/test_updatemanager.py'
2--- landscape/monitor/tests/test_updatemanager.py 2013-07-12 13:41:07 +0000
3+++ landscape/monitor/tests/test_updatemanager.py 2016-06-15 18:27:57 +0000
4@@ -1,7 +1,8 @@
5+import mock
6+
7 from landscape.monitor.updatemanager import UpdateManager
8 from landscape.tests.helpers import (
9 LandscapeTest, MonitorHelper, LogKeeperHelper)
10-from landscape.tests.mocker import ANY
11
12
13 class UpdateManagerTest(LandscapeTest):
14@@ -90,10 +91,10 @@
15 If the server can accept them, the plugin should send
16 C{update-manager} messages.
17 """
18- broker_mock = self.mocker.replace(self.remote)
19- broker_mock.send_message(ANY, ANY)
20- self.mocker.replay()
21- self.plugin.run()
22+ with mock.patch.object(self.remote, "send_message"):
23+ self.plugin.run()
24+ self.remote.send_message.assert_called_once_with(
25+ mock.ANY, mock.ANY)
26 self.mstore.set_accepted_types([])
27 self.plugin.run()
28

Subscribers

People subscribed via source and target branches

to all changes: