lp:~tribaal/charms/trusty/rabbitmq-server/fix-le-ignore-min-cluster

Branch merges

Propose for merging

No branches dependent on this one.

On hold for merging into lp:~openstack-charmers-archive/charms/trusty/rabbitmq-server/next

Ryan Beisner (community): Needs Information on 2015-10-13

Geoff Teale (community): Approve on 2015-10-12

OpenStack Charmers: Pending requested 2015-10-12

Diff: 204 lines (+52/-39)

4 files modified

Makefile (+1/-1)
hooks/rabbit_utils.py (+23/-23)
hooks/rabbitmq_server_relations.py (+19/-6)
unit_tests/test_rabbit_utils.py (+9/-9)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1500204: cloud install fails due to config-changed hook failure in rabbitmq-server service

High

Fix Released

Link a bug report

Related blueprints

125. By Chris Glass on 2015-10-13

Removed introduced test.

124. By Chris Glass on 2015-10-12

Added missing unit tests dependency while we're at it.

123. By Chris Glass on 2015-10-12

Empty commit to kick of OSCI again.

122. By Chris Glass on 2015-10-12

Fix typo.

121. By Chris Glass on 2015-10-12

Added more logging and a slightly clearer logic.

120. By Chris Glass on 2015-10-12

Add Amulet test for trusty/kilo/leader-election to ensure previously introduced
behavior actually works.

Some refactoring around unecessary looping.

119. By Adam Collard on 2015-10-09

Address the review comments I made on stable branch
 * leader_node() returns something or None
 * Fix the retry logic which was crazy bonkers wrong
 * Use better Python idioms

118. By Corey Bryant on 2015-10-07

[beisner,r=corey.bryant] Add Amulet test dependencies and clean up Makefile.

117. By Billy Olsen on 2015-10-07

[thedac,r=billy-olsen]

Ignore min-cluster-size when juju has leadership election.

This MP also addresses two major hurdles to rabbitmq clustering.

1) When more than one node has run stop_app at the same time
   nodes cannot join the cluster.

2) When using juju leadership election, if the elected leader
   is the third or greater node (i.e. rabbitmq/2 +), the leader
   would never be joined to the cluster.

Changing the clustering algorithm for each non-leader to join_cluster
with the leader resolves this. Also by clustering with the leader
rather than non-leader nodes we avoid split-brain clusters.

Closes-Bug: 1500204

116. By David Ames on 2015-10-05

[jamespage,r=thedac] Workload Status