Merge lp:~tribaal/charms/trusty/landscape-client/add-sync-makefile-target into lp:charms/trusty/landscape-client

Proposed by Chris Glass
Status: Merged
Approved by: Chris Glass
Approved revision: 43
Merged at revision: 42
Proposed branch: lp:~tribaal/charms/trusty/landscape-client/add-sync-makefile-target
Merge into: lp:charms/trusty/landscape-client
Diff against target: 29 lines (+15/-0)
2 files modified
.bzrignore (+1/-0)
Makefile (+14/-0)
To merge this branch: bzr merge lp:~tribaal/charms/trusty/landscape-client/add-sync-makefile-target
Reviewer Review Type Date Requested Status
David Britton Approve
Alberto Donato (community) Approve
Review via email: mp+226977@code.launchpad.net

Description of the change

This branch adds a "sync" target to the Makefile to easily sync changes made in charm helpers.

To post a comment you must log in.
42. By Chris Glass

Added small comment about the target name

Revision history for this message
Alberto Donato (ack) wrote :

Nice! +1

review: Approve
43. By Chris Glass

Made use of more variables (its now cleaner)

Revision history for this message
David Britton (dpb) wrote :

nice work, much easier. :) +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file '.bzrignore'
2--- .bzrignore 1970-01-01 00:00:00 +0000
3+++ .bzrignore 2014-07-16 09:03:43 +0000
4@@ -0,0 +1,1 @@
5+bin/
6
7=== modified file 'Makefile'
8--- Makefile 2013-10-09 14:47:18 +0000
9+++ Makefile 2014-07-16 09:03:43 +0000
10@@ -1,5 +1,19 @@
11+#!/usr/bin/make
12+PYTHON := /usr/bin/env python
13+SYNC_SCRIPT := bin/charm_helpers_sync.py
14+CONFIG := charm-helpers-sync.yaml
15+
16 test:
17 cd hooks && trial test_hooks.py
18
19 lint:
20 bzr ls-lint
21+
22+$(SYNC_SCRIPT):
23+ @mkdir -p bin
24+ @bzr cat lp:charm-helpers/tools/charm_helpers_sync/charm_helpers_sync.py \
25+ > $(SYNC_SCRIPT)
26+
27+# Note: The target name is unfortunate, but that's what other charms use.
28+sync: $(SYNC_SCRIPT)
29+ @$(PYTHON) $(SYNC_SCRIPT) -c $(CONFIG)

Subscribers

People subscribed via source and target branches