Code review comment for lp:~tribaal/charms/precise/storage/refactor-mount-volume

Revision history for this message
Chris Glass (tribaal) wrote :

Yes indeed, I think it can work better to change how the charm is structured instead - falling straight in the refactoring category :)

So to summarize the IRC discussion (for future reference):
I think I'll rename the storage-providers.d directory to just "storage-providers" or "providers" to make it a proper python module, so everything is one nice tidy tree and we don't need to muck around with PYTHONPATH.

I'll rewire as much as the tests as possible in this branch using this strategy - but the bulk of them will have to be rewritten. I'll try to do so to "best effort" in this branch, and will put another branch up for review doing most of the tests rewriting - nobody wants to decrease coverage, as others have rightfully pointed out.

Thanks a lot for the feedback - it's hard to get these big refactorings right without other eyes on the code. So thanks a lot for your time and pointers David and Cory :) I'll keep hammering at it some more :)

« Back to merge proposal