Merge lp:~tribaal/charms/precise/storage/make-local-provider-answer into lp:charms/storage

[Chris Glass]

This fixes the related bug. The local storage provider now simply answers the main charm immediately (since no IO is actually necessary).

[David Britton (dpb)]

I tested this with postgresql and noticed that the default charmhelpers mount creation algorithm has a bug with permissions and ownership. I'll file a bug on that separately, but that led me to think that we should be creating the directory in the local provider so it is ready to go for the caller.

a simple 'os.makedirs()' on the mountpoint if it does not exist would be helpful and expected IMO.

Other than this, things look great. I'll mark needs fixing until then.

review: Needs Fixing

[David Britton (dpb)]

Added: https://bugs.launchpad.net/charm-helpers/+bug/1361866

for the charmhelpers issue.

[Chris Glass (tribaal)]

Ohhh good catch, thanks. The charm I developed this for already has a mkdirs() call so I didn't see the issue. Will fix.

[lp:~tribaal/charms/precise/storage/make-local-provider-answer]

38. By Chris Glass on 2014-08-27

Added os.makedirs() call on the mountpoint to make sure it exists.

[Chris Glass (tribaal)]

Should be fixed now. Let me know if anything else is necessary.

[Stuart Bishop (stub)]

Looks good.

review: Approve

[David Britton (dpb)]

review: Approve

[Charles Butler (lazypower)]

Worked as advertised. LGTM +1

review: Approve

=== modified file 'hooks/storage-provider.d/local/data-relation-changed'
--- hooks/storage-provider.d/local/data-relation-changed	2013-11-29 22:23:56 +0000
+++ hooks/storage-provider.d/local/data-relation-changed	2014-08-27 05:58:23 +0000
@@ -1,3 +1,23 @@
-#!/bin/bash -e
-
-exit 0
+#!/usr/bin/python
+import sys
+import os
+
+from charmhelpers.core.hookenv import (
+    relation_get,
+    relation_set,
+    log
+)
+
+mountpoint = relation_get("mountpoint")
+
+if mountpoint is None:
+    log("No local mountpoint requested for now, noop.")
+    sys.exit(0)
+
+if not os.path.exists(mountpoint):
+    log("Requested mountpoint '%s' does not exist. Creating now." % mountpoint)
+    os.makedirs(mountpoint)
+
+log("Notifying the data relation that the mountpoint '%s' is ready "
+    "(it's local)." % mountpoint)
+relation_set(mountpoint=mountpoint)