lp:~tribaal/charm-helpers/stable-device-mounted-accepts-partitions

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:~openstack-charmers/charm-helpers/stable-1604 at revision 158

OpenStack Charmers: Pending requested 2014-08-13

Diff: 68 lines (+45/-1)

2 files modified

charmhelpers/contrib/storage/linux/utils.py (+3/-0)
tests/contrib/storage/test_linux_storage_utils.py (+42/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Bug #1350049: /dev/sdb got mounted root, 'guess' algorithm exludes /dev/sda (among others)	Low	Fix Released
Bug #1350051: charmhelpers is_mounted() doesn't deal with root device check?	Undecided	Fix Released

Link a bug report

Related blueprints

158. By Chris Glass on 2014-08-13

Make the is_device_mounted() helper accept partitions as well as devices.
This allows for calling code not to care about wether the device is a partition or a root device:
is_device_mounted("/dev/sda") is valid, and now is_device_mounted("/dev/sda1") is valid as well and should return sensible values.

157. By James Page on 2014-07-24

Cherry pick fix for apt race during version comparison

156. By James Page on 2014-07-14

[hopem,r=james-page] Fixup support for sectional configuration elements.

155. By James Page on 2014-06-25

Cherry pick additional fix for fstab persistence

154. By James Page on 2014-06-11

Cherry pick fix for fstab persistent from lp:charm-helpers

153. By James Page on 2014-05-19

[tribaal,r=james-page] Use in-memory cache when querying apt to avoid filesystem races

152. By Marco Ceppi on 2014-05-15

[tvansteenburgh] Add Config wrapper around charm config dictionary.

151. By James Page on 2014-05-15

[gnuoy,r=james-page] Add helper for comparing package versions

150. By Marco Ceppi on 2014-05-13

[tribaal] In case the passed device path does not exist, do not bother checking if it's a block device (return False instead of raising).
[tribaal] Add a "is_device_mounted" function to the storage utils on linux. This will be used in the cinder charm, and should replace the similar "device_mounted" function in the ceph charm. The Ceph charm function does not actually work, but since ceph does the right thing and skips devices with mounted partitions, we haven't noticed.

149. By Marco Ceppi on 2014-05-13

[tribaal] This branch refactors the fetch/__init__.py file to use a common _run_apt_command that retries in case the apt lock cannot be acquired.