Merge lp:~tribaal/charm-helpers/make-test-great-again into lp:charm-helpers
Status: | Merged |
---|---|
Merged at revision: | 678 |
Proposed branch: | lp:~tribaal/charm-helpers/make-test-great-again |
Merge into: | lp:charm-helpers |
Diff against target: |
51 lines (+2/-5) 3 files modified
Makefile (+0/-2) charmhelpers/contrib/network/ip.py (+1/-1) test_requirements.txt (+1/-2) |
To merge this branch: | bzr merge lp:~tribaal/charm-helpers/make-test-great-again |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stuart Bishop (community) | Approve | ||
Review via email: mp+315604@code.launchpad.net |
Description of the change
This branch fixes the project so that invoking "make test" runs the tests successfully on trusty, xenial, yakkety and zesty.
For the record despite comments in the changed files mentioning precise, tests don't run on precise regardless of this branch being merged in or not.
Note: one test fails if juju is not installed, but properly isolating the test (using a mock, for instance) is outside the scope of this MP.
Steps taken to test:
(repeated on trusty, xenial, yakkety and zesty on LXD)
lxc launch ubuntu:<series>
lxc exec <name> /bin/bash
apt update && apt upgrade
apt install bzr make juju # juju is needed because a test is not isolated properly
bzr co lp:~tribaal/charm-helpers/make-test-great-again
cd make-test-
make test
Is good.