~trebelnik-stefina/cinnamon-test/+git/python-xapp:master

Last commit made on 2024-02-05
Get this branch:
git clone -b master https://git.launchpad.net/~trebelnik-stefina/cinnamon-test/+git/python-xapp

Branch merges

Branch information

Recent commits

edbe920... by Matt Turnbull <email address hidden>

Make python installation configurable for distro packaging. (#23)

c2e2549... by Clement Lefebvre <email address hidden>

Revert "os.py: Add function to read the VERSION_CODENAME in /etc/os-release."

This reverts commit 1f94a501c779e01203461462eb562ec0d99ac515.

3a35853... by Clement Lefebvre <email address hidden>

Revert "os.py: rename get_os_release_codename() to get_os_release_info()"

This reverts commit 6d9d0e13a0b8f851e9cfd61b04617bb06e5b0949.

It was only used in mintupdate/mintsources. Both no longer use
it.

6d9d0e1... by Michael Webster

os.py: rename get_os_release_codename() to get_os_release_info()
and have it return a dictionary of os-release file's contents.

Some users need to query versions also.

1f94a50... by Michael Webster

os.py: Add function to read the VERSION_CODENAME in /etc/os-release.

409d2f2... by Clement Lefebvre <email address hidden>

2.4.1

0208ef7... by Michael Webster

Add workflow

630ea84... by Himadri Sekhar Basu <email address hidden>

fix lintian error and build failure (closes #21) (#22)

- fix build error due to missing build
  dependency: gobject-introspection
- fix lintian error: debian-rules-not-a-makefile

d3e11ed... by Clement Lefebvre <email address hidden>

2.4.0

ec428d7... by Mathias Krause <email address hidden>

Use access() to test readability of /proc/cmdline

Security focused distributions might limit the access to /proc/cmdline, making
a simple existence tests insufficient, leading to failures like below:

org.cinnamon.ScreenSaver[5058]: cat: /proc/cmdline: Permission denied
org.cinnamon.ScreenSaver[3308]: Traceback (most recent call last):
org.cinnamon.ScreenSaver[3308]: File "/usr/share/cinnamon-screensaver/service.py", line 105, in handle_set_active
org.cinnamon.ScreenSaver[3308]: self.manager.set_active(active)
org.cinnamon.ScreenSaver[3308]: File "/usr/share/cinnamon-screensaver/manager.py", line 123, in set_active
org.cinnamon.ScreenSaver[3308]: self.stage.activate(self.on_spawn_stage_complete)
org.cinnamon.ScreenSaver[3308]: File "/usr/share/cinnamon-screensaver/stage.py", line 237, in activate
org.cinnamon.ScreenSaver[3308]: callback()
org.cinnamon.ScreenSaver[3308]: File "/usr/share/cinnamon-screensaver/manager.py", line 340, in on_spawn_stage_complete
org.cinnamon.ScreenSaver[3308]: self.start_timers()
org.cinnamon.ScreenSaver[3308]: File "/usr/share/cinnamon-screensaver/manager.py", line 409, in start_timers
org.cinnamon.ScreenSaver[3308]: self.start_lock_delay()
org.cinnamon.ScreenSaver[3308]: File "/usr/share/cinnamon-screensaver/manager.py", line 445, in start_lock_delay
org.cinnamon.ScreenSaver[3308]: if not utils.user_can_lock():
org.cinnamon.ScreenSaver[3308]: File "/usr/share/cinnamon-screensaver/util/utils.py", line 73, in user_can_lock
org.cinnamon.ScreenSaver[3308]: if xapp.os.is_live_session() or xapp.os.is_guest_session():
org.cinnamon.ScreenSaver[3308]: File "/usr/lib/python3/dist-packages/xapp/os.py", line 47, in is_live_session
org.cinnamon.ScreenSaver[3308]: cmdline = subprocess.check_output("cat /proc/cmdline", shell = True).decode("utf-8")
org.cinnamon.ScreenSaver[3308]: File "/usr/lib/python3.10/subprocess.py", line 421, in check_output
org.cinnamon.ScreenSaver[3308]: return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
org.cinnamon.ScreenSaver[3308]: File "/usr/lib/python3.10/subprocess.py", line 526, in run
org.cinnamon.ScreenSaver[3308]: raise CalledProcessError(retcode, process.args,
org.cinnamon.ScreenSaver[3308]: subprocess.CalledProcessError: Command 'cat /proc/cmdline' returned non-zero exit status 1.

Use access(…, R_OK) instead to ensure the file is readable.

Signed-off-by: Mathias Krause <email address hidden>