Merge lp:~trb143/openlp/themecombo-24 into lp:openlp/2.4
Proposed by
Tim Bentley
Status: | Merged |
---|---|
Merged at revision: | 2649 |
Proposed branch: | lp:~trb143/openlp/themecombo-24 |
Merge into: | lp:openlp/2.4 |
Diff against target: |
66 lines (+40/-1) 2 files modified
openlp/core/ui/servicemanager.py (+1/-1) tests/functional/openlp_core_ui/test_servicemanager.py (+39/-0) |
To merge this branch: | bzr merge lp:~trb143/openlp/themecombo-24 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Raoul Snyman | Approve | ||
Review via email: mp+302865@code.launchpad.net |
Description of the change
Fix bug and fully test it.
lp:~trb143/openlp/themecombo-24 (revision 2649)
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
[SUCCESS] https:/
To post a comment you must log in.
Personally, I prefer multiple tests for each state (you can use setUp to do the common stuff necessary), as opposed to multiple scenarios within the same test, but this works.