Merge lp:~trapnine/maas/fix-1576417-controllers-admin-only into lp:~maas-committers/maas/trunk
Proposed by
Jeffrey C Jones
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Jeffrey C Jones | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 5027 | ||||
Proposed branch: | lp:~trapnine/maas/fix-1576417-controllers-admin-only | ||||
Merge into: | lp:~maas-committers/maas/trunk | ||||
Diff against target: |
357 lines (+135/-12) 11 files modified
src/maasserver/api/rackcontrollers.py (+2/-0) src/maasserver/api/tests/test_events.py (+2/-0) src/maasserver/api/tests/test_rackcontroller.py (+33/-0) src/maasserver/api/tests/test_regioncontroller.py (+1/-0) src/maasserver/api/tests/test_tag.py (+42/-6) src/maasserver/models/node.py (+8/-1) src/maasserver/models/tests/test_node.py (+21/-0) src/maasserver/static/js/angular/controllers/nodes_list.js (+5/-0) src/maasserver/static/js/angular/controllers/tests/test_nodes_list.js (+16/-0) src/maasserver/static/partials/nodes-list.html (+2/-2) src/maasserver/websockets/handlers/tests/test_controller.py (+3/-3) |
||||
To merge this branch: | bzr merge lp:~trapnine/maas/fix-1576417-controllers-admin-only | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jeffrey C Jones (community) | Approve | ||
Gavin Panella (community) | Approve | ||
Review via email: mp+294785@code.launchpad.net |
Commit message
Non-admins can't see controllers.
Description of the change
Non-admins can't see controllers.
To post a comment you must log in.
Looks good, except that isSuperUser needs a simple test.