Code review comment for lp:~tplavcic/percona-xtrabackup/bug1156209-2.2

Revision history for this message
Alexey Kopytov (akopytov) wrote :

General comments:

- shouldn't we remove doc/Makefile and doc/make.bat? That would also require re-imlementing the remaining bits from Makefile in doc/source/CMakeLists.txt. How much work would that require?

- please add a CMake configuration option (-DWITH_MAN_PAGES, ON by default) so that it would be possible to build xtrabackup without man pages on systems without sphinx installed.

review: Needs Fixing

« Back to merge proposal