Merge lp:~tplavcic/percona-server/ps-bld138-5.6 into lp:percona-server/5.6

Proposed by Tomislav Plavcic
Status: Merged
Approved by: Laurynas Biveinis
Approved revision: no longer in the source branch.
Merged at revision: 641
Proposed branch: lp:~tplavcic/percona-server/ps-bld138-5.6
Merge into: lp:percona-server/5.6
Diff against target: 40 lines (+7/-2)
1 file modified
build-ps/build-binary.sh (+7/-2)
To merge this branch: bzr merge lp:~tplavcic/percona-server/ps-bld138-5.6
Reviewer Review Type Date Requested Status
Laurynas Biveinis (community) Approve
Review via email: mp+229000@code.launchpad.net

Description of the change

Added option to build-binary.sh to build with yassl.

5.1 uses just --with-ssl (without path) when building with yassl
5.5 & 5.6 use --with-ssl=bundled (for yassl) and --with-ssl=system (for openssl)

Also for 5.5 it was removed "make UDF" from build-binary since it was ported to cmake (seems it was removed from 5.6 already).

It was tested with these builds:
http://jenkins.percona.com/view/TEST/job/percona-server-5.1-binaries-test-yassl/6/label_exp=centos6-64/
http://jenkins.percona.com/job/percona-server-5.5-binary-tarballs-test/label_exp=centos5-64/1/
http://jenkins.percona.com/job/percona-server-5.6-binaries-release-test/label_exp=centos6-64/8/

To post a comment you must log in.
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) wrote :

The description mentions 5.5 make UDF removal but there is only 5.6 MP?

review: Needs Information
Revision history for this message
Tomislav Plavcic (tplavcic) wrote :

Sorry, there is also 5.1 and 5.5 MP's but lp is showing that it is still updating those branches.
Will overwrite branches to see if it updates info, sometimes it just hangs like that forever.
I'll contact you when it's ok.

Revision history for this message
Tomislav Plavcic (tplavcic) wrote :
Revision history for this message
Laurynas Biveinis (laurynas-biveinis) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build-ps/build-binary.sh'
2--- build-ps/build-binary.sh 2014-07-17 14:24:55 +0000
3+++ build-ps/build-binary.sh 2014-07-31 09:35:48 +0000
4@@ -19,6 +19,7 @@
5 WITH_JEMALLOC=''
6 DEBUG_EXTNAME=''
7 WITH_SSL='/usr'
8+WITH_SSL_TYPE='system'
9 OPENSSL_INCLUDE=''
10 OPENSSL_LIBRARY=''
11 CRYPTO_LIBRARY=''
12@@ -34,7 +35,7 @@
13 if ! getopt --test
14 then
15 go_out="$(getopt --options=iqdvjt: \
16- --longoptions=i686,quiet,debug,valgrind,with-jemalloc:,with-ssl:,tag: \
17+ --longoptions=i686,quiet,debug,valgrind,with-jemalloc:,with-yassl,with-ssl:,tag: \
18 --name="$(basename "$0")" -- "$@")"
19 test $? -eq 0 || exit 1
20 eval set -- $go_out
21@@ -69,6 +70,10 @@
22 WITH_JEMALLOC="$1"
23 shift
24 ;;
25+ --with-yassl )
26+ shift
27+ WITH_SSL_TYPE="bundled"
28+ ;;
29 --with-ssl )
30 shift
31 WITH_SSL="$1"
32@@ -220,7 +225,7 @@
33 -DWITH_EMBEDDED_SERVER=OFF \
34 -DFEATURE_SET=community \
35 -DENABLE_DTRACE=OFF \
36- -DWITH_SSL=system \
37+ -DWITH_SSL="$WITH_SSL_TYPE" \
38 -DCMAKE_INSTALL_PREFIX="/usr/local/$PRODUCT_FULL" \
39 -DMYSQL_DATADIR="/usr/local/$PRODUCT_FULL/data" \
40 -DCOMPILATION_COMMENT="$COMMENT" \

Subscribers

People subscribed via source and target branches