Merge lp:~tpeeters/ubuntu-ui-toolkit/topMargin-bug1572525 into lp:ubuntu-ui-toolkit/staging
| Status: | Merged |
|---|---|
| Approved by: | Zsombor Egri on 2016-04-20 |
| Approved revision: | 1948 |
| Merged at revision: | 1946 |
| Proposed branch: | lp:~tpeeters/ubuntu-ui-toolkit/topMargin-bug1572525 |
| Merge into: | lp:ubuntu-ui-toolkit/staging |
| Diff against target: |
28 lines (+6/-6) 1 file modified
src/Ubuntu/Components/plugin/ucheader.cpp (+6/-6) |
| To merge this branch: | bzr merge lp:~tpeeters/ubuntu-ui-toolkit/topMargin-bug1572525 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| ubuntu-sdk-build-bot | continuous-integration | Approve on 2016-04-20 | |
| Zsombor Egri (community) | 2016-04-20 | Approve on 2016-04-20 | |
|
Review via email:
|
|||
Commit Message
Update Header.flickable docs.
| Andrea Bernabei (faenil) wrote : | # |
PASSED: Continuous integration, rev:1946
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:1946
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:1946
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
- 1947. By Tim Peeters on 2016-04-20
-
clarify docs
PASSED: Continuous integration, rev:1946
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:1946
https:/
Executed test runs:
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild:
https:/
| Zsombor Egri (zsombi) wrote : | # |
See inline.
- 1948. By Tim Peeters on 2016-04-20
-
revert --> restore
PASSED: Continuous integration, rev:1947
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:1947
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:1947
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:1947
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:1947
https:/
Executed test runs:
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:1948
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:1948
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:1948
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
PASSED: Continuous integration, rev:1948
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
"...and does not reflect the header height."
that is a bit unclear to me...what do you mean? Maybe we can it out? or does it actually add information? The topMargin wasn't reflecting the header height anyway (in the most generic case)