Merge lp:~tpeeters/ubuntu-ui-toolkit/test_the_units into lp:ubuntu-ui-toolkit/staging
- test_the_units
- Merge into staging
Status: | Merged |
---|---|
Approved by: | Zoltan Balogh |
Approved revision: | 2109 |
Merged at revision: | 2104 |
Proposed branch: | lp:~tpeeters/ubuntu-ui-toolkit/test_the_units |
Merge into: | lp:ubuntu-ui-toolkit/staging |
Diff against target: |
204 lines (+20/-5) 15 files modified
debian/rules (+1/-1) tests/unit/components/FIXME-QT56_pagestack_deprecated_toolbar.qml (+2/-0) tests/unit/unit.pro (+2/-2) tests/unit/units/units.pro (+2/-2) tests/unit/visual/FIXME-QT56_expandable.11.qml (+2/-0) tests/unit/visual/FIXME-QT56_listitem.12.qml (+1/-0) tests/unit/visual/FIXME-QT56_listitem.13.qml (+1/-0) tests/unit/visual/FIXME-QT56_listitem_focus.13.qml (+1/-0) tests/unit/visual/FIXME-QT56_pagehead_sections_bug1511839.13.qml (+2/-0) tests/unit/visual/FIXME-QT56_scrollbar.13.qml (+1/-0) tests/unit/visual/FIXME-QT56_scrollbar_header.13.qml (+1/-0) tests/unit/visual/FIXME-QT56_sections.13.qml (+1/-0) tests/unit/visual/FIXME-QT56_textarea.11.qml (+1/-0) tests/unit/visual/FIXME-QT56_textfield.11.qml (+1/-0) tests/unit/visual/FIXME-QT56_ubuntulistview.10.qml (+1/-0) |
To merge this branch: | bzr merge lp:~tpeeters/ubuntu-ui-toolkit/test_the_units |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
ubuntu-sdk-build-bot | continuous-integration | Approve | |
Zoltan Balogh | Approve | ||
Review via email:
|
Commit message
Do not skip Xenial and Yakkety series for running unit tests.
Individual unit tests that fail with Qt 5.6 have been disabled, and bugs are reported here: https:/
Description of the change
Do not skip Xenial and Yakkety series for running unit tests.
Individual unit tests that fail with Qt 5.6 have been disabled, and bugs are reported here: https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2104
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2104
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2104
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
FAILED: Continuous integration, rev:2104
https:/
Executed test runs:
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
FAILURE: https:/
SUCCESS: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild:
https:/
- 2105. By Tim Peeters
-
disable out cpp tests that break on qt 5.6
- 2106. By Tim Peeters
-
rename failing qml unit tests
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2106
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
- 2107. By Tim Peeters
-
add bug information in comments
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2106
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2106
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2106
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
- 2108. By Tim Peeters
-
add more bug references
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2106
https:/
Executed test runs:
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild:
https:/
- 2109. By Tim Peeters
-
add references to bug IDs
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2108
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2108
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2108
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2108
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2108
https:/
Executed test runs:
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2109
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2109
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2109
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2109
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2109
https:/
Executed test runs:
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
None: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
Zoltan Balogh (bzoltan) : | # |
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2109
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2109
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2109
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
![](/+icing/build/overlay/assets/skins/sam/images/close.gif)
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote : | # |
PASSED: Continuous integration, rev:2109
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild:
https:/
Preview Diff
1 | === modified file 'debian/rules' |
2 | --- debian/rules 2016-09-15 14:51:50 +0000 |
3 | +++ debian/rules 2016-09-16 11:21:18 +0000 |
4 | @@ -13,7 +13,7 @@ |
5 | |
6 | # Skip tests on the archs they are known to be flaky with current configuration |
7 | testskip_architectures := powerpc arm64 ppc64el s390x |
8 | -testskip_series := yakkety xenial |
9 | +testskip_series := |
10 | |
11 | override_dh_auto_configure: |
12 | qmake -r |
13 | |
14 | === renamed file 'tests/unit/components/tst_pagestack_deprecated_toolbar.qml' => 'tests/unit/components/FIXME-QT56_pagestack_deprecated_toolbar.qml' |
15 | --- tests/unit/components/tst_pagestack_deprecated_toolbar.qml 2016-06-03 15:39:07 +0000 |
16 | +++ tests/unit/components/FIXME-QT56_pagestack_deprecated_toolbar.qml 2016-09-16 11:21:18 +0000 |
17 | @@ -21,6 +21,8 @@ |
18 | // pagestack tests for the new header are in |
19 | // unit/visual/tst_pagestack_new_header.qml |
20 | |
21 | +// FIXME: These unit tests generate fatal warnings that must be fixed. See bug #1622577. |
22 | + |
23 | TestCase { |
24 | name: "PageStackAPI" |
25 | |
26 | |
27 | === modified file 'tests/unit/unit.pro' |
28 | --- tests/unit/unit.pro 2016-05-31 09:02:35 +0000 |
29 | +++ tests/unit/unit.pro 2016-09-16 11:21:18 +0000 |
30 | @@ -29,7 +29,7 @@ |
31 | mousefilters \ |
32 | animator \ |
33 | serviceproperties \ |
34 | - subtheming \ |
35 | +# subtheming \ # FIXME: Breaks with Qt 5.6. See bug #1570478. |
36 | swipearea \ |
37 | touchregistry \ |
38 | bottomedge \ |
39 | @@ -38,7 +38,7 @@ |
40 | units \ |
41 | scaling_image_provider \ |
42 | qquick_image_extension \ |
43 | - performance \ |
44 | +# performance \ # FIXME: Breaks with Qt 5.6. See bug #1570478. |
45 | mainview \ |
46 | i18n \ |
47 | arguments \ |
48 | |
49 | === modified file 'tests/unit/units/units.pro' |
50 | --- tests/unit/units/units.pro 2016-05-31 09:02:35 +0000 |
51 | +++ tests/unit/units/units.pro 2016-09-16 11:21:18 +0000 |
52 | @@ -2,6 +2,6 @@ |
53 | |
54 | SUBDIRS += \ |
55 | dpr1 \ |
56 | - dpr2 \ |
57 | - dpr3 \ |
58 | +# dpr2 \ # FIXME: Fails with Qt 5.6. See bug #1570478. |
59 | +# dpr3 \ # FIXME: Fails with Qt 5.6. See bug #1570478. |
60 | scale |
61 | |
62 | === renamed file 'tests/unit/visual/tst_datepicker.bug1567840.SEGFAULT.12.qml' => 'tests/unit/visual/FIXME-QT56_datepicker.bug1567840.SEGFAULT.12.qml' |
63 | === renamed file 'tests/unit/visual/tst_datepicker.bug1567840.SEGFAULT.13.qml' => 'tests/unit/visual/FIXME-QT56_datepicker.bug1567840.SEGFAULT.13.qml' |
64 | === renamed file 'tests/unit/visual/tst_expandable.11.qml' => 'tests/unit/visual/FIXME-QT56_expandable.11.qml' |
65 | --- tests/unit/visual/tst_expandable.11.qml 2016-06-15 13:46:51 +0000 |
66 | +++ tests/unit/visual/FIXME-QT56_expandable.11.qml 2016-09-16 11:21:18 +0000 |
67 | @@ -20,6 +20,8 @@ |
68 | import Ubuntu.Components 1.1 |
69 | import Ubuntu.Components.ListItems 1.0 |
70 | |
71 | +// FIXME: Unit tests fail with fatal warnings. See bug #1610230. |
72 | + |
73 | Item { |
74 | width: units.gu(40) |
75 | height: units.gu(60) |
76 | |
77 | === renamed file 'tests/unit/visual/tst_expandablescolumn.11.qml' => 'tests/unit/visual/FIXME-QT56_expandablescolumn.11.qml' |
78 | === renamed file 'tests/unit/visual/tst_listitem.12.qml' => 'tests/unit/visual/FIXME-QT56_listitem.12.qml' |
79 | --- tests/unit/visual/tst_listitem.12.qml 2016-08-05 14:55:11 +0000 |
80 | +++ tests/unit/visual/FIXME-QT56_listitem.12.qml 2016-09-16 11:21:18 +0000 |
81 | @@ -243,6 +243,7 @@ |
82 | wait(200); |
83 | } |
84 | |
85 | + // FIXME: Fails with Qt 5.6. See bug #1624328. |
86 | function test_0_defaults() { |
87 | verify(defaults.contentItem !== null, "Defaults is null"); |
88 | compare(defaults.color.toString(), Qt.rgba(0.0, 0.0, 0.0, 0.0).toString(), "Transparent by default"); |
89 | |
90 | === renamed file 'tests/unit/visual/tst_listitem.13.qml' => 'tests/unit/visual/FIXME-QT56_listitem.13.qml' |
91 | --- tests/unit/visual/tst_listitem.13.qml 2016-08-05 14:55:11 +0000 |
92 | +++ tests/unit/visual/FIXME-QT56_listitem.13.qml 2016-09-16 11:21:18 +0000 |
93 | @@ -243,6 +243,7 @@ |
94 | wait(200); |
95 | } |
96 | |
97 | + // FIXME: Fails with Qt 5.6. See bug #1624328. |
98 | function test_0_defaults() { |
99 | verify(defaults.contentItem !== null, "Defaults is null"); |
100 | compare(defaults.color.toString(), Qt.rgba(0.0, 0.0, 0.0, 0.0).toString(), "Transparent by default"); |
101 | |
102 | === renamed file 'tests/unit/visual/tst_listitem_focus.13.qml' => 'tests/unit/visual/FIXME-QT56_listitem_focus.13.qml' |
103 | --- tests/unit/visual/tst_listitem_focus.13.qml 2016-07-29 11:11:20 +0000 |
104 | +++ tests/unit/visual/FIXME-QT56_listitem_focus.13.qml 2016-09-16 11:21:18 +0000 |
105 | @@ -486,6 +486,7 @@ |
106 | } |
107 | } |
108 | |
109 | + // FIXME: Fails with Qt 5.6. See bug #1624331. |
110 | // re-focusing ListView will focus on the last focused item |
111 | function test_refocus_listview_on_last_focused_item_data() { |
112 | return [ |
113 | |
114 | === renamed file 'tests/unit/visual/tst_pagehead_sections_bug1511839.13.qml' => 'tests/unit/visual/FIXME-QT56_pagehead_sections_bug1511839.13.qml' |
115 | --- tests/unit/visual/tst_pagehead_sections_bug1511839.13.qml 2016-06-15 13:46:51 +0000 |
116 | +++ tests/unit/visual/FIXME-QT56_pagehead_sections_bug1511839.13.qml 2016-09-16 11:21:18 +0000 |
117 | @@ -40,6 +40,7 @@ |
118 | stack.push(pageComponent) |
119 | } |
120 | |
121 | + // FIXME: Tests failing with Qt 5.6. See bug #1624337. |
122 | UbuntuTestCase { |
123 | id: testCase |
124 | name: "Page.head.sections" |
125 | @@ -60,6 +61,7 @@ |
126 | compare(button.selected, isSelected, message); |
127 | } |
128 | |
129 | + // FIXME: Fails with Qt 5.6. See bug #1610231. |
130 | function test_bug1511839() { |
131 | for (var i = 0; i < stack.currentPage.head.sections.model.length; i++) { |
132 | verifySelectedSection(i, false, "Section " + i + " is selected."); |
133 | |
134 | === renamed file 'tests/unit/visual/tst_scrollbar.13.qml' => 'tests/unit/visual/FIXME-QT56_scrollbar.13.qml' |
135 | --- tests/unit/visual/tst_scrollbar.13.qml 2016-08-27 15:14:28 +0000 |
136 | +++ tests/unit/visual/FIXME-QT56_scrollbar.13.qml 2016-09-16 11:21:18 +0000 |
137 | @@ -155,6 +155,7 @@ |
138 | } |
139 | } |
140 | |
141 | + // FIXME: Tests failing with Qt 5.6. See bug #1624337. |
142 | ScrollbarTestCase13 { |
143 | name: "Scrollbar" |
144 | |
145 | |
146 | === renamed file 'tests/unit/visual/tst_scrollbar_header.13.qml' => 'tests/unit/visual/FIXME-QT56_scrollbar_header.13.qml' |
147 | --- tests/unit/visual/tst_scrollbar_header.13.qml 2016-06-15 13:46:51 +0000 |
148 | +++ tests/unit/visual/FIXME-QT56_scrollbar_header.13.qml 2016-09-16 11:21:18 +0000 |
149 | @@ -208,6 +208,7 @@ |
150 | } |
151 | } |
152 | |
153 | + // FIXME: Tests failing with Qt 5.6. See bug #1624337. |
154 | ScrollbarTestCase13 { |
155 | name: "Scrollbar" |
156 | |
157 | |
158 | === renamed file 'tests/unit/visual/tst_sections.13.qml' => 'tests/unit/visual/FIXME-QT56_sections.13.qml' |
159 | --- tests/unit/visual/tst_sections.13.qml 2016-06-15 13:46:51 +0000 |
160 | +++ tests/unit/visual/FIXME-QT56_sections.13.qml 2016-09-16 11:21:18 +0000 |
161 | @@ -142,6 +142,7 @@ |
162 | name: "SectionsApi" |
163 | when: windowShown |
164 | |
165 | + // FIXME: Fails with Qt 5.6. See bug #1610231. |
166 | function initTestCase() { |
167 | // The initially selected actions must be triggered. |
168 | compare(label.text, "First action triggered.", |
169 | |
170 | === renamed file 'tests/unit/visual/tst_textarea.11.qml' => 'tests/unit/visual/FIXME-QT56_textarea.11.qml' |
171 | --- tests/unit/visual/tst_textarea.11.qml 2016-06-15 13:46:51 +0000 |
172 | +++ tests/unit/visual/FIXME-QT56_textarea.11.qml 2016-09-16 11:21:18 +0000 |
173 | @@ -137,6 +137,7 @@ |
174 | compare(textArea.canUndo,textEdit.canUndo,"TextArea.canUndo is same as TextEdit.canUndo") |
175 | } |
176 | |
177 | + // FIXME: Fails with Qt 5.6. See bug #1624342. |
178 | function test_0_color() { |
179 | compare(textArea.color,textEdit.color,"TextArea.color is same as TextEdit.canUndo") |
180 | } |
181 | |
182 | === renamed file 'tests/unit/visual/tst_textfield.11.qml' => 'tests/unit/visual/FIXME-QT56_textfield.11.qml' |
183 | --- tests/unit/visual/tst_textfield.11.qml 2016-06-15 13:46:51 +0000 |
184 | +++ tests/unit/visual/FIXME-QT56_textfield.11.qml 2016-09-16 11:21:18 +0000 |
185 | @@ -164,6 +164,7 @@ |
186 | compare(textField.cursorPosition, 0, "cursorPosition 0 by default") |
187 | } |
188 | |
189 | + // FIXME: Fails with Qt 5.6. See bug #1624340. |
190 | function test_0_cursorRectangle() { |
191 | compare(textField.cursorRectangle, Qt.rect(0, 0, 0, 0), "cursorRectangle 0 by default") |
192 | } |
193 | |
194 | === renamed file 'tests/unit/visual/tst_ubuntulistview.10.qml' => 'tests/unit/visual/FIXME-QT56_ubuntulistview.10.qml' |
195 | --- tests/unit/visual/tst_ubuntulistview.10.qml 2016-06-15 13:46:51 +0000 |
196 | +++ tests/unit/visual/FIXME-QT56_ubuntulistview.10.qml 2016-09-16 11:21:18 +0000 |
197 | @@ -65,6 +65,7 @@ |
198 | } |
199 | } |
200 | |
201 | + // FIXME: Failing unit tests with Qt 5.6. See bug #1624343. |
202 | UbuntuTestCase { |
203 | name: "UbuntuListView" |
204 | when: windowShown |
FAILED: Continuous integration, rev:2104 /jenkins. ubuntu. com/ubuntu- sdk/job/ ubuntu- ui-toolkit- ci-amd64- devel/1201/ /jenkins. ubuntu. com/ubuntu- sdk/job/ generic- update- mp/6370/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /jenkins. ubuntu. com/ubuntu- sdk/job/ ubuntu- ui-toolkit- ci-amd64- devel/1201/ rebuild
https:/