Code review comment for lp:~tpeeters/ubuntu-ui-toolkit/lessHeaderDisabling

Victor Thompson (vthompson) wrote :

In order to source the built plugins I need to make the following change to the export_modules_dir.sh file (otherwise dirname $0 evaluated to /bin). It'd be nice to make this change if exporting the modules the way the README suggests doesn't work for others--could be user error:

bzr diff
=== modified file 'export_modules_dir.sh'
--- export_modules_dir.sh 2015-05-19 07:55:27 +0000
+++ export_modules_dir.sh 2015-11-19 02:03:27 +0000
@@ -15,7 +15,7 @@
 # along with this program. If not, see <http://www.gnu.org/licenses/>.
 #

-. `dirname $0`/build_paths.inc
+. ./build_paths.inc
 export QML_IMPORT_PATH=$BUILD_DIR/qml
 export QML2_IMPORT_PATH=$BUILD_DIR/qml
 export UBUNTU_UI_TOOLKIT_THEMES_PATH=$BUILD_DIR/qml

Otherwise, this works great!

review: Approve

« Back to merge proposal