Merge lp:~tpeeters/ubuntu-ui-toolkit/gallery-subtitle into lp:ubuntu-ui-toolkit/staging

Proposed by Tim Peeters
Status: Merged
Approved by: Cris Dywan
Approved revision: 1961
Merged at revision: 1963
Proposed branch: lp:~tpeeters/ubuntu-ui-toolkit/gallery-subtitle
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 71 lines (+41/-14)
1 file modified
examples/ubuntu-ui-toolkit-gallery/PageHeaders.qml (+41/-14)
To merge this branch: bzr merge lp:~tpeeters/ubuntu-ui-toolkit/gallery-subtitle
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Cris Dywan Approve
Review via email: mp+293141@code.launchpad.net

Commit message

Add header subtitle example in gallery.

To post a comment you must log in.
1961. By Tim Peeters

clean

Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Cris Dywan (kalikiana) wrote :

Love it! Thanks!

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'examples/ubuntu-ui-toolkit-gallery/PageHeaders.qml'
2--- examples/ubuntu-ui-toolkit-gallery/PageHeaders.qml 2016-02-17 14:45:09 +0000
3+++ examples/ubuntu-ui-toolkit-gallery/PageHeaders.qml 2016-04-27 16:13:27 +0000
4@@ -26,7 +26,47 @@
5 className: "PageHeader"
6
7 Label {
8- text: "Use the icons in the header."
9+ text: "Use the icons in the header for search and edit header."
10+ }
11+
12+ Grid {
13+ id: switchGrid
14+ columns: 2
15+ spacing: units.gu(1)
16+ anchors {
17+ left: parent.left
18+ leftMargin: units.gu(5)
19+ }
20+
21+ Switch {
22+ id: lockedSwitch
23+ checked: standardHeader.extension
24+ onTriggered: {
25+ if (standardHeader.extension) {
26+ standardHeader.extension = null;
27+ } else {
28+ standardHeader.extension = sections;
29+ }
30+ }
31+ }
32+ Label {
33+ text: "Sections"
34+ }
35+
36+ Switch {
37+ id: subtitleSwitch
38+ checked: standardHeader.subtitle
39+ onTriggered: {
40+ if (standardHeader.subtitle) {
41+ standardHeader.subtitle = "";
42+ } else {
43+ standardHeader.subtitle = "Hello, this is your subtitle";
44+ }
45+ }
46+ }
47+ Label {
48+ text: "Subtitle"
49+ }
50 }
51 }
52
53@@ -44,19 +84,6 @@
54 iconName: "edit"
55 text: "Edit"
56 onTriggered: page.header = editHeader
57- },
58- Action {
59- iconName: standardHeader.extension === sections
60- ? "media-playback-stop"
61- : "filters"
62- text: "Sections"
63- onTriggered: {
64- if (standardHeader.extension) {
65- standardHeader.extension = null;
66- } else {
67- standardHeader.extension = sections;
68- }
69- }
70 }
71 ]
72

Subscribers

People subscribed via source and target branches