Merge lp:~tpeeters/ubuntu-ui-toolkit/fix-header-ap-landing into lp:~bzoltan/ubuntu-ui-toolkit/OTA9_landing_2015-12-05

Proposed by Tim Peeters
Status: Merged
Merged at revision: 1744
Proposed branch: lp:~tpeeters/ubuntu-ui-toolkit/fix-header-ap-landing
Merge into: lp:~bzoltan/ubuntu-ui-toolkit/OTA9_landing_2015-12-05
Diff against target: 44 lines (+2/-16)
2 files modified
tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_actionbar.py (+2/-2)
tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_header.py (+0/-14)
To merge this branch: bzr merge lp:~tpeeters/ubuntu-ui-toolkit/fix-header-ap-landing
Reviewer Review Type Date Requested Status
Ubuntu SDK team Pending
Review via email: mp+279783@code.launchpad.net

Description of the change

Fix several header CPO related issues.

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_actionbar.py'
2--- tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_actionbar.py 2015-10-05 10:52:11 +0000
3+++ tests/autopilot/ubuntuuitoolkit/_custom_proxy_objects/_actionbar.py 2015-12-07 14:20:31 +0000
4@@ -60,7 +60,7 @@
5 """
6
7 try:
8- object_name = action_object_name + "_action_button"
9+ object_name = action_object_name + "_button"
10 button = self.select_single(objectName=object_name)
11 self.pointing_device.click_object(button)
12 except dbus.StateNotFoundError:
13@@ -68,6 +68,6 @@
14 try:
15 popover = self._open_overflow()
16 popover.click_action_button(action_object_name)
17- except dbus.StateNotFoundError:
18+ except _common.ToolkitException:
19 raise _common.ToolkitException(
20 'Button not found in ActionBar or overflow')
21
22=== modified file 'tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_header.py'
23--- tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_header.py 2015-10-01 14:51:53 +0000
24+++ tests/autopilot/ubuntuuitoolkit/tests/custom_proxy_objects/test_header.py 2015-12-07 14:20:31 +0000
25@@ -110,20 +110,6 @@
26 self.header.click_action_button('action0')
27 self.assertEqual(self.label.text, 'Button 0 clicked.')
28
29- def test_overflow_button(self):
30- # there are 5 actions plus a custom back action
31- overflow_button = self.header.select_single(
32- objectName='actions_overflow_button')
33- self.assertEqual(overflow_button.visible, True)
34-
35- hide_actions_button = self.main_view.select_single(
36- 'Button',
37- objectName='hide_actions_button')
38- self.pointing_device.click_object(hide_actions_button)
39-
40- # only three actions are visible
41- self.assertEqual(overflow_button.visible, False)
42-
43
44 class SectionsTestCase(tests.QMLFileAppTestCase):
45

Subscribers

People subscribed via source and target branches

to all changes: