Merge lp:~tpeeters/ubuntu-ui-toolkit/deprecateSubHeader into lp:ubuntu-ui-toolkit/staging
Proposed by
Tim Peeters
Status: | Merged |
---|---|
Approved by: | Cris Dywan |
Approved revision: | 2000 |
Merged at revision: | 1998 |
Proposed branch: | lp:~tpeeters/ubuntu-ui-toolkit/deprecateSubHeader |
Merge into: | lp:ubuntu-ui-toolkit/staging |
Diff against target: |
48 lines (+14/-0) 3 files modified
src/Ubuntu/Components/1.3/AdaptivePageLayout.qml (+3/-0) src/Ubuntu/Components/Styles/1.3/PageHeadStyle.qml (+1/-0) src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeadStyle.qml (+10/-0) |
To merge this branch: | bzr merge lp:~tpeeters/ubuntu-ui-toolkit/deprecateSubHeader |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
ubuntu-sdk-build-bot | continuous-integration | Approve | |
Cris Dywan | Approve | ||
Review via email: mp+296919@code.launchpad.net |
Commit message
Draw a red outline around the subheader in AdaptivePageLayout to warn that the old header is deprecated.
Description of the change
As announced on the ubuntu-phone mailing list. PageHeader should be used instead of the Page.head property.
You can use tst_multicolumn
To post a comment you must log in.
PASSED: Continuous integration, rev:1999 /jenkins. ubuntu. com/ubuntu- sdk/job/ ubuntu- ui-toolkit- ci-amd64- stable/ 892/ /jenkins. ubuntu. com/ubuntu- sdk/job/ generic- update- mp/3615/ console
https:/
Executed test runs:
None: https:/
Click here to trigger a rebuild: /jenkins. ubuntu. com/ubuntu- sdk/job/ ubuntu- ui-toolkit- ci-amd64- stable/ 892/rebuild
https:/