Merge lp:~tpeeters/ubuntu-ui-toolkit/commentStateBug into lp:ubuntu-ui-toolkit

Proposed by Tim Peeters
Status: Merged
Approved by: Florian Boucault
Approved revision: 514
Merged at revision: 514
Proposed branch: lp:~tpeeters/ubuntu-ui-toolkit/commentStateBug
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 14 lines (+4/-0)
1 file modified
modules/Ubuntu/Components/PageWrapperUtils.js (+4/-0)
To merge this branch: bzr merge lp:~tpeeters/ubuntu-ui-toolkit/commentStateBug
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu SDK team Pending
Review via email: mp+165621@code.launchpad.net

Commit message

comment on pragma library in PageWrapperUtils.js

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/PageWrapperUtils.js'
2--- modules/Ubuntu/Components/PageWrapperUtils.js 2013-05-23 17:45:35 +0000
3+++ modules/Ubuntu/Components/PageWrapperUtils.js 2013-05-24 13:52:28 +0000
4@@ -15,6 +15,10 @@
5 */
6
7 //.pragma library // FIXME: cannot refer to Component.Error if I use this.
8+// FIXME: ideally we would make this a stateless library, but that breaks applications
9+// that rely on accessing context variables in pages that were pushed on a PageStack
10+// by url (PageStack.push("FileName.qml")) because of a Qt bug:
11+// https://bugreports.qt-project.org/browse/QTBUG-31347
12
13 /*!
14 \internal

Subscribers

People subscribed via source and target branches

to status/vote changes: