Merge lp:~tpeeters/ubuntu-ui-toolkit/70-sectionsLandscape into lp:ubuntu-ui-toolkit/staging

Proposed by Tim Peeters
Status: Merged
Approved by: Zsombor Egri
Approved revision: 1876
Merged at revision: 1875
Proposed branch: lp:~tpeeters/ubuntu-ui-toolkit/70-sectionsLandscape
Merge into: lp:ubuntu-ui-toolkit/staging
Diff against target: 68 lines (+7/-5)
2 files modified
src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeadStyle.qml (+2/-1)
src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml (+5/-4)
To merge this branch: bzr merge lp:~tpeeters/ubuntu-ui-toolkit/70-sectionsLandscape
Reviewer Review Type Date Requested Status
ubuntu-sdk-build-bot continuous-integration Approve
Zsombor Egri Approve
Review via email: mp+287498@code.launchpad.net

Commit message

Sections and old AppHeader landscape mode.

Description of the change

Specs for header with sections in landscape: http://client.demo.haus/header/header-landscape-sections/

To post a comment you must log in.
1876. By Tim Peeters

link bug

Revision history for this message
Zsombor Egri (zsombi) wrote :

Looks good.

review: Approve
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
ubuntu-sdk-build-bot (ubuntu-sdk-build-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeadStyle.qml'
2--- src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeadStyle.qml 2016-01-27 15:17:56 +0000
3+++ src/Ubuntu/Components/Themes/Ambiance/1.3/PageHeadStyle.qml 2016-02-29 17:31:18 +0000
4@@ -14,6 +14,7 @@
5 * along with this program. If not, see <http://www.gnu.org/licenses/>.
6 */
7 import QtQuick 2.4
8+import QtQuick.Window 2.0
9 import Ubuntu.Components 1.3
10 import Ubuntu.Components.Popups 1.3
11 import Ubuntu.Components.Styles 1.3 as Style
12@@ -21,7 +22,7 @@
13 Style.PageHeadStyle {
14 id: headerStyle
15 objectName: "PageHeadStyle" // used in unit tests
16- contentHeight: units.gu(6)
17+ contentHeight: Screen.height > units.gu(50) ? units.gu(6) : units.gu(5)
18 fontWeight: Font.Light
19 textSize: Label.Large
20 textLeftMargin: units.gu(2)
21
22=== modified file 'src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml'
23--- src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml 2016-02-26 10:13:15 +0000
24+++ src/Ubuntu/Components/Themes/Ambiance/1.3/SectionsStyle.qml 2016-02-29 17:31:18 +0000
25@@ -14,6 +14,7 @@
26 * along with this program. If not, see <http://www.gnu.org/licenses/>.
27 */
28 import QtQuick 2.4
29+import QtQuick.Window 2.2
30 import Ubuntu.Components 1.3
31 import QtGraphicalEffects 1.0
32 import Ubuntu.Components.Private 1.3
33@@ -22,7 +23,7 @@
34 id: sectionsStyle
35
36 implicitWidth: sectionsListView.contentWidth + 2 * listViewContainer.listViewMargins
37- implicitHeight: units.gu(4)
38+ implicitHeight: Screen.height > units.gu(50) ? units.gu(4) : units.gu(3)
39
40 /*!
41 The foreground color of unselected sections.
42@@ -208,7 +209,7 @@
43 font.weight: Font.Light
44 anchors {
45 baseline: underline.bottom
46- baselineOffset: -units.gu(2)
47+ baselineOffset: sectionsStyle.height < units.gu(4) ? -units.gu(1) : -units.gu(2)
48 horizontalCenter: parent.horizontalCenter
49 }
50
51@@ -296,7 +297,7 @@
52 left: parent.left
53 leftMargin: (listViewContainer.listViewMargins - width) / 2
54 bottom: parent.bottom
55- bottomMargin: units.gu(2)
56+ bottomMargin: sectionsStyle.height < units.gu(4) ? units.gu(1) : units.gu(2)
57 }
58 width: units.gu(1)
59 height: units.gu(1)
60@@ -319,7 +320,7 @@
61 right: parent.right
62 rightMargin: (listViewContainer.listViewMargins - width) / 2
63 bottom: parent.bottom
64- bottomMargin: units.gu(2)
65+ bottomMargin: sectionsStyle.height < units.gu(4) ? units.gu(1) : units.gu(2)
66 }
67 width: units.gu(1)
68 height: units.gu(1)

Subscribers

People subscribed via source and target branches